build/vs_toolchain.py - Issue 1580703002: Ensure GYP_MSVS_VERSION is set for GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/vs_toolchain.py

Issue 1580703002: Ensure GYP_MSVS_VERSION is set for GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/vs_toolchain.py

diff --git a/build/vs_toolchain.py b/build/vs_toolchain.py

index 1fd8a11445b275fce2be9029d85aadbcb6d75799..d259b25737a0e87d1f432161b5016c3ed7797cdd 100755

--- a/build/vs_toolchain.py

+++ b/build/vs_toolchain.py

@@ -107,6 +107,7 @@ def DetectVisualStudioPath():

# Default to Visual Studio 2013 for now.

version_as_year = os.environ.get('GYP_MSVS_VERSION', '2013')

+ os.environ['GYP_MSVS_VERSION'] = version_as_year

Daniel Bratell 2016/01/12 08:42:02 From a code maintenance point of view it doesn't s

year_to_version = {

'2013': '12.0',

'2015': '14.0',

« no previous file with comments | « no previous file | no next file » | no next file with comments »