Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1580693002:
[Proxies] Ship Proxies + Reflect (Closed)
|
Created:
4 years, 11 months ago by Michael Hablich Modified:
4 years, 11 months ago CC:
v8-reviews_googlegroups.com, rmcilroy, oth Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[Proxies] Ship Proxies + Reflect
BUG=v8:3931, v8:1543
LOG=Y
R=verwaest@chromium.org, rossberg@chromium.org
Committed: https://crrev.com/9ce5162fd2a36daf318e0ec3838cd90f4e179168
Cr-Commit-Position: refs/heads/master@{#33234}
Patch Set 1 #Patch Set 2 : Disable failing ignition test #
Messages
Total messages: 25 (11 generated)
The CQ bit was checked by hablich@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580693002/1
lgtm
The CQ bit was unchecked by hablich@chromium.org
The CQ bit was checked by hablich@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580693002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/12853)
lgtm
On 2016/01/12 08:41:13, Toon Verwaest wrote: > lgtm Some tests fail in combination with WASM. Ben is working on a fix. If this is not fixed until noon I am going to deactivate failing the tests for now.
The CQ bit was checked by hablich@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580693002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)
Description was changed from ========== [Proxies] Ship Proxies + Reflect BUG=v8:3931,v8:1543 LOG=Y R=verwaest@chromium.org, rossberg@chromium.org ========== to ========== [Proxies] Ship Proxies + Reflect BUG=v8:3931,v8:1543 LOG=Y R=verwaest@chromium.org, rossberg@chromium.org ==========
On 2016/01/12 11:14:52, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, > http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...) I disabled the failing ignition tests.
The CQ bit was checked by hablich@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rossberg@chromium.org, verwaest@chromium.org Link to the patchset: https://codereview.chromium.org/1580693002/#ps20001 (title: "Disable failing ignition test")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580693002/20001
Message was sent while issue was closed.
Description was changed from ========== [Proxies] Ship Proxies + Reflect BUG=v8:3931,v8:1543 LOG=Y R=verwaest@chromium.org, rossberg@chromium.org ========== to ========== [Proxies] Ship Proxies + Reflect BUG=v8:3931,v8:1543 LOG=Y R=verwaest@chromium.org, rossberg@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Proxies] Ship Proxies + Reflect BUG=v8:3931,v8:1543 LOG=Y R=verwaest@chromium.org, rossberg@chromium.org ========== to ========== [Proxies] Ship Proxies + Reflect BUG=v8:3931,v8:1543 LOG=Y R=verwaest@chromium.org, rossberg@chromium.org Committed: https://crrev.com/9ce5162fd2a36daf318e0ec3838cd90f4e179168 Cr-Commit-Position: refs/heads/master@{#33234} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9ce5162fd2a36daf318e0ec3838cd90f4e179168 Cr-Commit-Position: refs/heads/master@{#33234}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1579573004/ by machenbach@chromium.org. The reason for reverting is: [Sheriff] Breaks layout tests. Please fix upstream first. https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2032/bui... https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui.... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
