Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1635)

Issue 1580693002: [Proxies] Ship Proxies + Reflect (Closed)

Created:
4 years, 11 months ago by Michael Hablich
Modified:
4 years, 11 months ago
Reviewers:
rossberg, Toon Verwaest
CC:
v8-reviews_googlegroups.com, rmcilroy, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Proxies] Ship Proxies + Reflect BUG=v8:3931, v8:1543 LOG=Y R=verwaest@chromium.org, rossberg@chromium.org Committed: https://crrev.com/9ce5162fd2a36daf318e0ec3838cd90f4e179168 Cr-Commit-Position: refs/heads/master@{#33234}

Patch Set 1 #

Patch Set 2 : Disable failing ignition test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/flag-definitions.h View 2 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
Michael Hablich
4 years, 11 months ago (2016-01-12 08:17:45 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580693002/1
4 years, 11 months ago (2016-01-12 08:17:56 UTC) #3
rossberg
lgtm
4 years, 11 months ago (2016-01-12 08:21:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580693002/1
4 years, 11 months ago (2016-01-12 08:23:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/12853)
4 years, 11 months ago (2016-01-12 08:40:19 UTC) #9
Toon Verwaest
lgtm
4 years, 11 months ago (2016-01-12 08:41:13 UTC) #10
Michael Hablich
On 2016/01/12 08:41:13, Toon Verwaest wrote: > lgtm Some tests fail in combination with WASM. ...
4 years, 11 months ago (2016-01-12 09:17:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580693002/1
4 years, 11 months ago (2016-01-12 10:38:32 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/13846)
4 years, 11 months ago (2016-01-12 11:14:52 UTC) #15
Michael Hablich
On 2016/01/12 11:14:52, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 11 months ago (2016-01-12 11:19:25 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580693002/20001
4 years, 11 months ago (2016-01-12 11:19:39 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-12 11:50:19 UTC) #22
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9ce5162fd2a36daf318e0ec3838cd90f4e179168 Cr-Commit-Position: refs/heads/master@{#33234}
4 years, 11 months ago (2016-01-12 11:51:08 UTC) #24
Michael Achenbach
4 years, 11 months ago (2016-01-12 13:07:12 UTC) #25
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1579573004/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks layout tests. Please fix upstream
first.

https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2032/bui...
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....

Powered by Google App Engine
This is Rietveld 408576698