Issue 1580643004: Fix finalization of recursive type graph with bounds (issue 25389).

Issue 1580643004: Fix finalization of recursive type graph with bounds (issue 25389). (Closed)

Created:
4 years, 11 months ago by regis

Modified:
4 years, 11 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix finalization of recursive type graph with bounds (issue 25389). Add regression test. Rename malformed_error to bound_error. Fix internal name of bounded type (broken by a previous cl). R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/ca1d105c5a110d356801a517d79550bff338a9bb

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -51 lines)			Patch
M	runtime/vm/flow_graph_compiler_arm.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	5 chunks	+32 lines, -7 lines	0 comments	Download
M	runtime/vm/parser.cc	View	5 chunks	+13 lines, -13 lines	0 comments	Download
A	tests/language/regress_25389_part.dart	View	1 chunk	+15 lines, -0 lines	0 comments	Download
A +	tests/language/regress_25389_test.dart	View	1 chunk	+7 lines, -10 lines	0 comments	Download

Total messages: 5 (2 generated)

regis

4 years, 11 months ago (2016-01-13 19:19:18 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ca1d105c5a110d356801a517d79550bff338a9bb (presubmit successful).