Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 15806005: fix the compare nil ic (Closed)

Created:
7 years, 7 months ago by oliv
Modified:
7 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

fix some names in compare nil ic The compare nil ic introduces a mechanism called lightweight miss. The idea is to insert a direct call to the miss handler instead of going through the deopt routine. This can be use for uninitialized stubs, to directly jump to the runtime. This cl 1. Cleans up naming 2. localizes the lightweight miss functionality on the only user (compare nil ic) 3. fixes DoCodegen, to actually call the correct method (uninitialized vs initialized) BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14798

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -60 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/code-stubs.h View 1 2 16 chunks +40 lines, -36 lines 0 comments Download
M src/code-stubs.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/code-stubs-hydrogen.cc View 1 3 chunks +11 lines, -10 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ic.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/stub-cache.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
oliv
should not change perf http://108.170.219.0:8080/Comparison#targetA%3Dv8%3BmachineTypeA%3Dlinux-ia32%3BrevisionA%3D14777%3BpatchA%3Dolivf-fix_compar_nil_ic%3BtargetB%3Dv8%3BmachineTypeB%3Dlinux-ia32%3BrevisionB%3D14777%3BpatchB%3DNone
7 years, 7 months ago (2013-05-23 14:56:42 UTC) #1
Toon Verwaest
lgtm https://codereview.chromium.org/15806005/diff/5001/src/code-stubs-hydrogen.cc File src/code-stubs-hydrogen.cc (right): https://codereview.chromium.org/15806005/diff/5001/src/code-stubs-hydrogen.cc#newcode210 src/code-stubs-hydrogen.cc:210: return BuildCodeInitializedStub(); Nice catch. So confusing.
7 years, 7 months ago (2013-05-24 10:59:16 UTC) #2
oliv
7 years, 7 months ago (2013-05-24 11:45:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r14798 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698