Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4838)

Unified Diff: chrome/browser/io_thread.cc

Issue 1580583002: Add a whitelist for QUIC hosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/io_thread.cc
diff --git a/chrome/browser/io_thread.cc b/chrome/browser/io_thread.cc
index cc7872f5efc962fa7e2d6533fe823dad312db444..a5f5e9e2694f55e4a93a3da248da88e538d65023 100644
--- a/chrome/browser/io_thread.cc
+++ b/chrome/browser/io_thread.cc
@@ -1178,6 +1178,8 @@ void IOThread::InitializeNetworkSessionParamsFromGlobals(
&params->quic_idle_connection_timeout_seconds);
globals.quic_disable_preconnect_if_0rtt.CopyToIfSet(
&params->quic_disable_preconnect_if_0rtt);
+ if (!globals.quic_host_whitelist.empty())
+ params->quic_host_whitelist = globals.quic_host_whitelist;
globals.origin_to_force_quic_on.CopyToIfSet(
&params->origin_to_force_quic_on);
@@ -1317,6 +1319,8 @@ void IOThread::ConfigureQuicGlobals(
}
globals->quic_disable_preconnect_if_0rtt.set(
ShouldQuicDisablePreConnectIfZeroRtt(quic_trial_params));
+ globals->quic_host_whitelist =
+ GetQuicHostWhitelist(command_line, quic_trial_params);
}
size_t max_packet_length = GetQuicMaxPacketLength(command_line,
@@ -1576,6 +1580,19 @@ bool IOThread::ShouldQuicDisablePreConnectIfZeroRtt(
"true");
}
+std::vector<std::string> IOThread::GetQuicHostWhitelist(
+ const base::CommandLine& command_line,
+ const VariationParameters& quic_trial_params) {
+ std::string whitelist;
+ if (command_line.HasSwitch(switches::kQuicHostWhitelist)) {
+ whitelist = command_line.GetSwitchValueASCII(switches::kQuicHostWhitelist);
+ } else {
+ whitelist = GetVariationParam(quic_trial_params, "quic_host_whitelist");
+ }
+ return base::SplitString(whitelist, ",", base::TRIM_WHITESPACE,
+ base::SPLIT_WANT_ALL);
+}
+
size_t IOThread::GetQuicMaxPacketLength(
const base::CommandLine& command_line,
const VariationParameters& quic_trial_params) {

Powered by Google App Engine
This is Rietveld 408576698