core/include/fpdfapi/fpdf_parser.h - Issue 1580573002: Replace more CFX_MapPtrToPtr and remove it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/include/fpdfapi/fpdf_parser.h

Issue 1580573002: Replace more CFX_MapPtrToPtr and remove it. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: And remove it. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/include/fpdfapi/fpdf_parser.h

diff --git a/core/include/fpdfapi/fpdf_parser.h b/core/include/fpdfapi/fpdf_parser.h

index bdddfc37d7bf1325a0b0e621434496a6900e9cfc..ad4f1f9a9a2e4d982ed8937ada15d5f4be50e245 100644

--- a/core/include/fpdfapi/fpdf_parser.h

+++ b/core/include/fpdfapi/fpdf_parser.h

@@ -545,7 +545,7 @@ class CPDF_Parser {

FX_DWORD m_dwXrefStartObjNum;

// A map of object numbers to indirect streams. Map owns the streams.

- CFX_MapPtrToPtr m_ObjectStreamMap;

+ std::map<FX_DWORD, std::unique_ptr<CPDF_StreamAcc>> m_ObjectStreamMap;

Oliver Chang 2016/01/20 21:34:24 awesome, we can do this now?

Tom Sepez 2016/01/20 22:18:30 On 2016/01/20 21:34:24, Oliver Chang wrote: Yes, S

// Mapping of object numbers to offsets. The offsets are relative to the first

// object in the stream.