Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1580513002: Roll HarfBuzz to 1.1.3 (Closed)

Created:
4 years, 11 months ago by drott
Modified:
4 years, 11 months ago
Reviewers:
kojii, eae, behdad
CC:
chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll HarfBuzz to 1.1.3 This should greatly improve performance of the AAT backend in cases where glyphs are not found. BUG=547912 R=kojii,eae,behdad Committed: https://crrev.com/e32c23d735f8b3caa72bea1baccf9a4d5f4b5f00 Cr-Commit-Position: refs/heads/master@{#368678}

Patch Set 1 #

Patch Set 2 : build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1768 lines, -787 lines) Patch
M third_party/harfbuzz-ng/NEWS View 1 chunk +44 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/README.chromium View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-atomic-private.hh View 1 chunk +25 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-blob.h View 3 chunks +12 lines, -12 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-buffer.h View 9 chunks +174 lines, -80 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-buffer.cc View 45 chunks +281 lines, -116 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-buffer-private.hh View 2 chunks +18 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-buffer-serialize.cc View 8 chunks +62 lines, -26 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-common.h View 4 chunks +20 lines, -17 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-common.cc View 5 chunks +28 lines, -17 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-coretext.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-coretext.cc View 2 chunks +40 lines, -5 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-face.h View 2 chunks +17 lines, -17 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-fallback-shape.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-font.h View 19 chunks +126 lines, -60 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-font.cc View 5 chunks +102 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-font-private.hh View 5 chunks +40 lines, -3 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ft.h View 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ft.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-glib.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-glib.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-gobject-structs.h View 1 chunk +13 lines, -13 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-graphite2.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-graphite2.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-icu.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-open-type-private.hh View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-font.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-font.cc View 6 chunks +61 lines, -3 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-head-table.hh View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout.h View 17 chunks +28 lines, -28 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout.cc View 12 chunks +23 lines, -13 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-common-private.hh View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-gpos-table.hh View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-gsubgpos-private.hh View 2 chunks +9 lines, -3 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-private.hh View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-map.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-map-private.hh View 1 chunk +2 lines, -1 line 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-os2-table.hh View 1 1 chunk +105 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape.cc View 7 chunks +13 lines, -6 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic.cc View 7 chunks +22 lines, -19 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-default.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-hebrew.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic.cc View 6 chunks +32 lines, -25 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic-private.hh View 2 chunks +25 lines, -15 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic-table.cc View 45 chunks +212 lines, -160 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-myanmar.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-private.hh View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-thai.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-tibetan.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-use.cc View 7 chunks +16 lines, -8 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-normalize.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-tag.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-tag.cc View 1 5 chunks +28 lines, -4 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-private.hh View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-set.h View 1 chunk +26 lines, -26 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-shape.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-shape.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-shape-plan.h View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-shaper-list.hh View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-unicode.h View 11 chunks +42 lines, -26 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-version.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/harfbuzz-ng/src/test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
drott
build fix
4 years, 11 months ago (2016-01-11 19:42:31 UTC) #2
drott
4 years, 11 months ago (2016-01-11 19:43:43 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580513002/20001
4 years, 11 months ago (2016-01-11 19:43:59 UTC) #5
eae
LGTM
4 years, 11 months ago (2016-01-11 19:50:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580513002/20001
4 years, 11 months ago (2016-01-11 21:37:59 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-11 21:46:46 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 21:47:42 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e32c23d735f8b3caa72bea1baccf9a4d5f4b5f00
Cr-Commit-Position: refs/heads/master@{#368678}

Powered by Google App Engine
This is Rietveld 408576698