third_party/WebKit/Source/core/dom/IntersectionObserver.cpp - Issue 1580503003: Eliminate superfluous clearing of weak pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObserver.cpp

Issue 1580503003: Eliminate superfluous clearing of weak pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Eliminate superfluous WeakPtrFactory::clear() Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/IntersectionObserver.cpp

diff --git a/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp b/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp

index f7c0ea902854a0b9e9833a5072a400d7df61814c..7a84be31d400be073323f8e0940e8abe7d31ab55 100644

--- a/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp

+++ b/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp

@@ -160,7 +160,6 @@ void IntersectionObserver::disconnect()

for (auto& observation : observationsToDisconnect)

observation->disconnect();

ASSERT(m_observations.isEmpty());

- m_root.clear();

}

void IntersectionObserver::removeObservation(IntersectionObservation& observation)

« no previous file with comments | « third_party/WebKit/Source/core/dom/IntersectionObservation.cpp ('k') | no next file » | no next file with comments »