Make the copy of GURL in src/url buildable as a component build. (try 2)

Make the copy of GURL in src/url buildable as a component build. (try 2)

BUG=229660
TBR=brettw

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203025

[Lei Zhang, 2013-05-29 02:54:42]

Having our own url.dll and a system url.dll confused WinXP. How about we name it
url_lib.dll as Thiago suggested?

[tfarina, 2013-05-29 03:00:57]

lgtm if Brett is fine with url_lib.

https://codereview.chromium.org/15805003/diff/8001/url/gurl.h
File url/gurl.h (right):

https://codereview.chromium.org/15805003/diff/8001/url/gurl.h#newcode23
url/gurl.h:23: URL_EXPORT GURL();
I'm not sure if this was intentional, otherwise I'd have expected class
URL_EXPORT GURL { ... };

See for reference: https://codereview.chromium.org/2939004

https://codereview.chromium.org/15805003/diff/8001/url/url_export.h
File url/url_export.h (right):

https://codereview.chromium.org/15805003/diff/8001/url/url_export.h#newcode31
url/url_export.h:31: #endif
// defined(COMPONENT_BUILD)

[Lei Zhang, 2013-05-29 03:23:25]

https://codereview.chromium.org/15805003/diff/8001/url/gurl.h
File url/gurl.h (right):

https://codereview.chromium.org/15805003/diff/8001/url/gurl.h#newcode23
url/gurl.h:23: URL_EXPORT GURL();
On 2013/05/29 03:00:57, tfarina wrote:
> I'm not sure if this was intentional, otherwise I'd have expected class
> URL_EXPORT GURL { ... };
> 
> See for reference: https://codereview.chromium.org/2939004

Done.

https://codereview.chromium.org/15805003/diff/8001/url/url_export.h
File url/url_export.h (right):

https://codereview.chromium.org/15805003/diff/8001/url/url_export.h#newcode31
url/url_export.h:31: #endif
On 2013/05/29 03:00:57, tfarina wrote:
> // defined(COMPONENT_BUILD)

Done.

[brettw, 2013-05-29 20:18:04]

url_lib seems OK

[commit-bot: I haz the power, 2013-05-29 20:19:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/15805003/24002

[commit-bot: I haz the power, 2013-05-29 20:29:43]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Lei Zhang, 2013-05-29 20:38:43]

On 2013/05/29 20:29:43, I haz the power (commit-bot) wrote:
> Retried try job too often on chromium_presubmit for step(s) presubmit
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

brettw: I need a real l-g-t-m

[commit-bot: I haz the power, 2013-05-29 22:05:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/15805003/24002

[commit-bot: I haz the power, 2013-05-30 00:39:58]

Change committed as 203025

[Lei Zhang, 2013-05-30 00:49:00]

On 2013/05/30 00:39:58, I haz the power (commit-bot) wrote:
> Change committed as 203025

Passed CQ, but failed the main waterfall again.

Linux ChromiumOS Builder says:
gyp: Dependency
'/b/build/slave/chromium-rel-linux-chromeos/build/src/url/url.gyp:url#target'
not found while trying to load target
/b/build/slave/chromium-rel-linux-chromeos/build/src/third_party/WebKit/Source/weborigin/weborigin_tests.gyp:weborigin_unittests#target

Will go for try 3 tonight...

[Lei Zhang, 2013-05-30 01:11:28]

On 2013/05/30 00:49:00, Lei Zhang wrote:
> On 2013/05/30 00:39:58, I haz the power (commit-bot) wrote:
> > Change committed as 203025
> 
> Passed CQ, but failed the main waterfall again.
> 
> Linux ChromiumOS Builder says:
> gyp: Dependency
> '/b/build/slave/chromium-rel-linux-chromeos/build/src/url/url.gyp:url#target'
> not found while trying to load target
>
/b/build/slave/chromium-rel-linux-chromeos/build/src/third_party/WebKit/Source/weborigin/weborigin_tests.gyp:weborigin_unittests#target
> 
> Will go for try 3 tonight...

Actually, the blink roll that screwed this up got reverted. So I'll revert the
revert and this CL should land tonight.

[tfarina, 2013-05-30 23:02:33]

On Wednesday, May 29, 2013, wrote:

> On 2013/05/30 00:49:00, Lei Zhang wrote:
>
>> On 2013/05/30 00:39:58, I haz the power (commit-bot) wrote:
>> > Change committed as 203025
>>
>
>  Passed CQ, but failed the main waterfall again.
>>
>
>  Linux ChromiumOS Builder says:
>> gyp: Dependency
>> '/b/build/slave/chromium-rel-**linux-chromeos/build/src/url/**
>> url.gyp:url#target'
>> not found while trying to load target
>>
>
> /b/build/slave/chromium-rel-**linux-chromeos/build/src/**
> third_party/WebKit/Source/**weborigin/weborigin_tests.gyp:**
> weborigin_unittests#target
>
>  Will go for try 3 tonight...
>>
>
> Actually, the blink roll that screwed this up got reverted. So I'll revert
> the
> revert and this CL should land tonight.
>
> I think James fixed the problem in Blink. Can we try relanding this again?


>
https://codereview.chromium.**org/15805003/<https://codereview.chromium.org/1...
>


-- 
Thiago

[Lei Zhang, 2013-05-30 23:03:53]

Waiting for blink rolls so the version used in chromium includes the fix.