chrome/browser/resources/options/search_engine_manager.js - Issue 15805002: Modify extension omnibox keywords to be user-configurable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/search_engine_manager.js

Issue 15805002: Modify extension omnibox keywords to be user-configurable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test updates Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/options/search_engine_manager_engine_list.js » ('j') | chrome/browser/search_engines/template_url_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/search_engine_manager.js

diff --git a/chrome/browser/resources/options/search_engine_manager.js b/chrome/browser/resources/options/search_engine_manager.js

index dc5cf25179fc4c18c7f1b0eed2fc0c2dfc663a46..7d8df03c1aea5d5f1aa8e7b53e842b33b5bedde0 100644

--- a/chrome/browser/resources/options/search_engine_manager.js

+++ b/chrome/browser/resources/options/search_engine_manager.js

@@ -37,7 +37,8 @@ cr.define('options', function() {

/**

* List for extension keywords.

* @private

- extensionList_ : null,

+ */

+ extensionList_: null,

/** inheritDoc */

initializePage: function() {

@@ -112,12 +113,13 @@ cr.define('options', function() {

};

SearchEngineManager.validityCheckCallback = function(validity, modelIndex) {

- // Forward to both lists; the one without a matching modelIndex will ignore

- // it.

+ // Forward to all lists; those without a matching modelIndex will ignore it.

SearchEngineManager.getInstance().defaultsList_.validationComplete(

validity, modelIndex);

SearchEngineManager.getInstance().othersList_.validationComplete(

validity, modelIndex);

+ SearchEngineManager.getInstance().extensionList_.validationComplete(

+ validity, modelIndex);

};

// Export