chrome/browser/ui/webui/options/search_engine_manager_handler.h - Issue 15805002: Modify extension omnibox keywords to be user-configurable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/search_engine_manager_handler.h

Issue 15805002: Modify extension omnibox keywords to be user-configurable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/search_engines/template_url_table_model.cc ('K') | « chrome/browser/ui/search_engines/template_url_table_model.cc ('k') | chrome/browser/ui/webui/options/search_engine_manager_handler.cc » ('j') | chrome/browser/ui/webui/options/search_engine_manager_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/search_engine_manager_handler.h

diff --git a/chrome/browser/ui/webui/options/search_engine_manager_handler.h b/chrome/browser/ui/webui/options/search_engine_manager_handler.h

index e28d6a59e1dfbfde326de2f4b237817b605b6000..05ea43b0b7fda307ef0f64dd3ff6c64132e67d05 100644

--- a/chrome/browser/ui/webui/options/search_engine_manager_handler.h

+++ b/chrome/browser/ui/webui/options/search_engine_manager_handler.h

@@ -72,7 +72,8 @@ class SearchEngineManagerHandler : public OptionsPageUIHandler,

void EditCompleted(const base::ListValue* args);

// Returns a dictionary to pass to WebUI representing the given search engine.

- base::DictionaryValue* CreateDictionaryForEngine(int index, bool is_default);

+ base::DictionaryValue* CreateDictionaryForEngine(int index, bool is_default,

+ bool is_extension);

Devlin 2013/05/24 02:42:54 each parameter on own line, or all three on a newl

Aaron Jacobs 2013/05/24 03:06:14 Done.

// Returns a dictionary to pass to WebUI representing the extension.

base::DictionaryValue* CreateDictionaryForExtension(