Modify extension omnibox keywords to be user-configurable

chrome/browser/resources/options/search_engine_manager.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   /** @const */ var OptionsPage = options.OptionsPage;
   /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
 
   /**
    * Encapsulated handling of search engine management page.
    * @constructor
    */
   function SearchEngineManager() {
     this.activeNavTab = null;
     OptionsPage.call(this, 'searchEngines',
                      loadTimeData.getString('searchEngineManagerPageTabTitle'),
                      'search-engine-manager-page');
   }
 
   cr.addSingletonGetter(SearchEngineManager);
 
   SearchEngineManager.prototype = {
     __proto__: OptionsPage.prototype,
 
     /**
      * List for default search engine options.
      * @private
      */
     defaultsList_: null,

[Dan Beam, 2013/05/31 03:33:56]

I didn't see that it was in the same class, sorry about that... you can leave it
as it was if you'd like.

If you like this way, move each ES5 getter under the property itself, i.e.

  defaultsList_: null,
  get defaultsList() {
    return this.defaultsList_;
  },

sorry for the mix up and thanks for the work!

[Aaron Jacobs, 2013/06/03 22:48:33]

Done.

 
     /**
      * List for other search engine options.
      * @private
      */
     othersList_: null,
 
     /**
      * List for extension keywords.
      * @private
-    extensionList_ : null,
+     */
+    extensionList_: null,
+
+    get defaultsList() {
+      return this.defaultsList_;
+    },
+
+    get othersList() {
+      return this.othersList_;
+    },
+
+    get extensionList() {
+      return this.extensionList_;
+    },
 
     /** inheritDoc */
     initializePage: function() {
       OptionsPage.prototype.initializePage.call(this);
 
       this.defaultsList_ = $('default-search-engine-list');
       this.setUpList_(this.defaultsList_);
 
       this.othersList_ = $('other-search-engine-list');
       this.setUpList_(this.othersList_);
@@ skipping 54 matching lines @@
 
   SearchEngineManager.updateSearchEngineList = function(defaultEngines,
                                                         otherEngines,
                                                         keywords) {
     SearchEngineManager.getInstance().updateSearchEngineList_(defaultEngines,
                                                               otherEngines,
                                                               keywords);
   };
 
   SearchEngineManager.validityCheckCallback = function(validity, modelIndex) {
-    // Forward to both lists; the one without a matching modelIndex will ignore
-    // it.
-    SearchEngineManager.getInstance().defaultsList_.validationComplete(
+    // Forward to all lists; those without a matching modelIndex will ignore it.
+    SearchEngineManager.getInstance().defaultsList.validationComplete(
         validity, modelIndex);
-    SearchEngineManager.getInstance().othersList_.validationComplete(
+    SearchEngineManager.getInstance().othersList.validationComplete(
+        validity, modelIndex);
+    SearchEngineManager.getInstance().extensionList.validationComplete(
         validity, modelIndex);
   };
 
   // Export
   return {
     SearchEngineManager: SearchEngineManager
   };
 
 });