content/renderer/media/renderer_webmediaplayer_delegate.h - Issue 1580493004: Plumb audio focus support for spitzer clients.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/renderer_webmediaplayer_delegate.h

Issue 1580493004: Plumb audio focus support for spitzer clients. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@delegate_hookup

Patch Set: Fix crash, plumb. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/media/media_web_contents_observer.cc ('K') | « content/renderer/media/audio_renderer_mixer_manager.cc ('k') | content/renderer/media/renderer_webmediaplayer_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/renderer_webmediaplayer_delegate.h

diff --git a/content/renderer/media/renderer_webmediaplayer_delegate.h b/content/renderer/media/renderer_webmediaplayer_delegate.h

index ccf031948af6b5d0548ad7be69e2dbadf5437327..f79fc32d92cb433aa34d243b21b616ae310829c6 100644

--- a/content/renderer/media/renderer_webmediaplayer_delegate.h

+++ b/content/renderer/media/renderer_webmediaplayer_delegate.h

@@ -33,11 +33,10 @@ class RendererWebMediaPlayerDelegate

bool has_played_media() const { return has_played_media_; }

// WebMediaPlayerDelegate implementation.

- void DidPlay(blink::WebMediaPlayer* player) override;

- void DidPause(blink::WebMediaPlayer* player) override;

- void PlayerGone(blink::WebMediaPlayer* player) override;

void AddObserver(Observer* observer) override;

- void RemoveObserver(Observer* observer) override;

+ void DidPlay(Observer* observer) override;

+ void DidPause(Observer* observer) override;

+ void PlayerGone(Observer* observer) override;

bool IsHidden() override;

// content::RenderFrameObserver overrides.

@@ -51,7 +50,6 @@ class RendererWebMediaPlayerDelegate

bool has_played_media_ = false;

base::ObserverList<Observer> observer_list_;

- std::set<blink::WebMediaPlayer*> players_;

DISALLOW_COPY_AND_ASSIGN(RendererWebMediaPlayerDelegate);

};