pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart - Issue 1580493003: dart2js: remove resolved TODO

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart

Issue 1580493003: dart2js: remove resolved TODO (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart

diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart

index da57c4a7a32ad56c0d5fe16ba445588e199a2e2a..4a96fe18630bc8aafc9424d458e4d14562ad72ed 100644

--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart

+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart

@@ -1426,8 +1426,6 @@ class IrBuilder {

Selectors.current,

currentMask,

emptyArguments));

- // TODO(sra): Does this cover all cases? The general setter case include

- // super.

// TODO(johnniwinther): Extract this as a provided strategy.

if (Elements.isLocal(variableElement)) {

bodyBuilder.buildLocalVariableSet(variableElement, currentValue);

« no previous file with comments | « no previous file | no next file » | no next file with comments »