Issue 1580493003: dart2js: remove resolved TODO

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1580493003: dart2js: remove resolved TODO (Closed)

Created:
4 years, 11 months ago by Harry Terkelsen

Modified:
4 years, 11 months ago

Reviewers:
sra, sra1

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js: remove resolved TODO The answer to the question in the TODO ("does this cover all cases?") is yes. In Dart, the LHS of a for-in loop must be an identifier. It cannot be a super access or a static variable access (unless that variable is in scope). BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/41dde543fed9ca14f9e6b1870ba64266fcfebc50

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 6 (3 generated)

Harry Terkelsen

4 years, 11 months ago (2016-01-11 23:41:25 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
41dde543fed9ca14f9e6b1870ba64266fcfebc50 (presubmit successful).