Stop treating scopes containing template strings tagged with 'eval' specially

Stop treating scopes containing template strings tagged with 'eval' specially

There's no need to mark these as possibly-direct-eval, since all such an
eval-tagged string will ever get passed is the array of string parts, which
will be immediately returns (since it's not a string). It will
never do a lookup in the current scope, nor (in sloppy mode) introduce
new declarations.

This patch is not intended to change behavior, but I've added tests that
demonstrate the stuff explained in the preceding paragraph.

Committed: https://crrev.com/f5828cb4db5257c221dc1e6fe508972942828332
Cr-Commit-Position: refs/heads/master@{#33245}

[adamk, 2016-01-11 23:12:48]

adamk@chromium.org changed reviewers:
+ caitpotter88@gmail.com, rossberg@chromium.org

[adamk, 2016-01-11 23:13:43]

Description was changed from

==========
Stop treating scopes containing template strings tagged with 'eval' specially

There's no need to mark these as possibly-direct-eval, since all such an
eval-tagged string will ever do is the array of string parts: it will
never do a lookup in the current scope, nor (in sloppy mode) introduce
new declarations.
==========

to

==========
Stop treating scopes containing template strings tagged with 'eval' specially

There's no need to mark these as possibly-direct-eval, since all such an
eval-tagged string will ever do is the array of string parts: it will
never do a lookup in the current scope, nor (in sloppy mode) introduce
new declarations.

This patch is not intended to change behavior, but I've added tests that
demonstrate the stuff explained in the preceding paragraph.
==========

[adamk, 2016-01-11 23:19:07]

Description was changed from

==========
Stop treating scopes containing template strings tagged with 'eval' specially

There's no need to mark these as possibly-direct-eval, since all such an
eval-tagged string will ever do is the array of string parts: it will
never do a lookup in the current scope, nor (in sloppy mode) introduce
new declarations.

This patch is not intended to change behavior, but I've added tests that
demonstrate the stuff explained in the preceding paragraph.
==========

to

==========
Stop treating scopes containing template strings tagged with 'eval' specially

There's no need to mark these as possibly-direct-eval, since all such an
eval-tagged string will ever get passed is the array of string parts, which
will be immediately returns (since it's not a string). It will
never do a lookup in the current scope, nor (in sloppy mode) introduce
new declarations.

This patch is not intended to change behavior, but I've added tests that
demonstrate the stuff explained in the preceding paragraph.
==========

[rossberg, 2016-01-12 10:49:59]

lgtm

[adamk, 2016-01-12 16:32:26]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2016-01-12 16:32:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1580463003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1580463003/1

[commit-bot: I haz the power, 2016-01-12 18:08:57]

Description was changed from

==========
Stop treating scopes containing template strings tagged with 'eval' specially

There's no need to mark these as possibly-direct-eval, since all such an
eval-tagged string will ever get passed is the array of string parts, which
will be immediately returns (since it's not a string). It will
never do a lookup in the current scope, nor (in sloppy mode) introduce
new declarations.

This patch is not intended to change behavior, but I've added tests that
demonstrate the stuff explained in the preceding paragraph.
==========

to

==========
Stop treating scopes containing template strings tagged with 'eval' specially

There's no need to mark these as possibly-direct-eval, since all such an
eval-tagged string will ever get passed is the array of string parts, which
will be immediately returns (since it's not a string). It will
never do a lookup in the current scope, nor (in sloppy mode) introduce
new declarations.

This patch is not intended to change behavior, but I've added tests that
demonstrate the stuff explained in the preceding paragraph.
==========

[commit-bot: I haz the power, 2016-01-12 18:08:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-12 18:09:20]

Description was changed from

==========
Stop treating scopes containing template strings tagged with 'eval' specially

There's no need to mark these as possibly-direct-eval, since all such an
eval-tagged string will ever get passed is the array of string parts, which
will be immediately returns (since it's not a string). It will
never do a lookup in the current scope, nor (in sloppy mode) introduce
new declarations.

This patch is not intended to change behavior, but I've added tests that
demonstrate the stuff explained in the preceding paragraph.
==========

to

==========
Stop treating scopes containing template strings tagged with 'eval' specially

There's no need to mark these as possibly-direct-eval, since all such an
eval-tagged string will ever get passed is the array of string parts, which
will be immediately returns (since it's not a string). It will
never do a lookup in the current scope, nor (in sloppy mode) introduce
new declarations.

This patch is not intended to change behavior, but I've added tests that
demonstrate the stuff explained in the preceding paragraph.

Committed: https://crrev.com/f5828cb4db5257c221dc1e6fe508972942828332
Cr-Commit-Position: refs/heads/master@{#33245}
==========

[commit-bot: I haz the power, 2016-01-12 18:09:21]

Patchset 1 (id:??) landed as
https://crrev.com/f5828cb4db5257c221dc1e6fe508972942828332
Cr-Commit-Position: refs/heads/master@{#33245}