Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 15804004: Windows perf bots: fixes android pylib initialization. (Closed)

Created:
7 years, 6 months ago by bulach
Modified:
7 years, 6 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Windows perf bots: fixes android pylib initialization. Following crrev.com/202558, android's pylib was initialized on platforms that didn't need. Check for platform and also make it safer to use should there be problems with "which". BUG=242960 R=tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M build/android/pylib/__init__.py View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bulach
sorry about the breakage.
7 years, 6 months ago (2013-05-28 16:26:42 UTC) #1
tonyg
lgtm
7 years, 6 months ago (2013-05-28 16:47:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/15804004/1
7 years, 6 months ago (2013-05-28 16:48:33 UTC) #3
ramant (doing other things)
On 2013/05/28 16:48:33, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 6 months ago (2013-05-28 19:22:03 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=154603
7 years, 6 months ago (2013-05-28 20:25:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/15804004/1
7 years, 6 months ago (2013-05-28 20:26:36 UTC) #6
Julien - ping for review
Committed patchset #1 manually as r202669 (presubmit successful).
7 years, 6 months ago (2013-05-28 22:25:09 UTC) #7
bulach
7 years, 6 months ago (2013-05-29 09:27:30 UTC) #8
Message was sent while issue was closed.
thanks all for landing this, apologies again for the breakage.

Powered by Google App Engine
This is Rietveld 408576698