Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1580363002: Implement FloatRect::squaredDistanceTo function (Closed)

Created:
4 years, 11 months ago by hyunjunekim2
Modified:
4 years, 11 months ago
Reviewers:
pdr., fs
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement FloatRect::squaredDistanceTo function This function is that calculate distance squared between Rectangle and Point. BUG=445329 Committed: https://crrev.com/ac7237a24b28daa6f1c5292f32e940cc63fba39d Cr-Commit-Position: refs/heads/master@{#369334}

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatRect.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/FloatRect.cpp View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/geometry/FloatRectTest.cpp View 1 2 3 4 5 1 chunk +114 lines, -0 lines 0 comments Download

Messages

Total messages: 37 (20 generated)
hyunjunekim2
pdr, Could you check this CL? Thank you.
4 years, 11 months ago (2016-01-13 07:39:23 UTC) #10
fs
Touched up the description a bit. I kind of like the "clamp" version (which runs ...
4 years, 11 months ago (2016-01-13 10:22:03 UTC) #12
hyunjunekim2
On 2016/01/13 10:22:03, fs wrote: > Touched up the description a bit. > > I ...
4 years, 11 months ago (2016-01-13 10:44:23 UTC) #13
hyunjunekim2
On 2016/01/13 10:44:23, hyunjunekim2 wrote: > On 2016/01/13 10:22:03, fs wrote: > > Touched up ...
4 years, 11 months ago (2016-01-13 10:49:50 UTC) #14
hyunjunekim2
fs, Could you check PS3? Thank you.
4 years, 11 months ago (2016-01-13 13:55:41 UTC) #17
hyunjunekim2
On 2016/01/13 13:55:41, hyunjunekim2 wrote: > fs, Could you check PS3? Thank you. PS4, replace ...
4 years, 11 months ago (2016-01-13 14:17:34 UTC) #18
fs
https://codereview.chromium.org/1580363002/diff/60001/third_party/WebKit/Source/platform/geometry/FloatRect.cpp File third_party/WebKit/Source/platform/geometry/FloatRect.cpp (right): https://codereview.chromium.org/1580363002/diff/60001/third_party/WebKit/Source/platform/geometry/FloatRect.cpp#newcode174 third_party/WebKit/Source/platform/geometry/FloatRect.cpp:174: float FloatRect::distanceTo(const FloatPoint& point) const squaredDistanceTo https://codereview.chromium.org/1580363002/diff/60001/third_party/WebKit/Source/platform/geometry/FloatRect.cpp#newcode177 third_party/WebKit/Source/platform/geometry/FloatRect.cpp:177: closestPoint.setX(clampTo<float>(point.x(), ...
4 years, 11 months ago (2016-01-13 14:36:17 UTC) #19
hyunjunekim2
On 2016/01/13 14:36:17, fs wrote: > https://codereview.chromium.org/1580363002/diff/60001/third_party/WebKit/Source/platform/geometry/FloatRect.cpp > File third_party/WebKit/Source/platform/geometry/FloatRect.cpp (right): > > https://codereview.chromium.org/1580363002/diff/60001/third_party/WebKit/Source/platform/geometry/FloatRect.cpp#newcode174 > ...
4 years, 11 months ago (2016-01-13 15:01:59 UTC) #20
fs
On 2016/01/13 at 15:01:59, hyunjune.kim wrote: > On 2016/01/13 14:36:17, fs wrote: > > https://codereview.chromium.org/1580363002/diff/60001/third_party/WebKit/Source/platform/geometry/FloatRect.cpp ...
4 years, 11 months ago (2016-01-13 15:17:33 UTC) #23
fs
On 2016/01/13 at 15:17:33, fs wrote: > On 2016/01/13 at 15:01:59, hyunjune.kim wrote: > > ...
4 years, 11 months ago (2016-01-13 15:18:36 UTC) #24
hyunjunekim2
pdr, Could you check this CL?
4 years, 11 months ago (2016-01-13 23:15:56 UTC) #26
pdr.
On 2016/01/13 at 23:15:56, hyunjune.kim wrote: > pdr, Could you check this CL? Nice! LGTM
4 years, 11 months ago (2016-01-13 23:50:54 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580363002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580363002/100001
4 years, 11 months ago (2016-01-14 01:00:41 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on ...
4 years, 11 months ago (2016-01-14 03:14:18 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580363002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580363002/100001
4 years, 11 months ago (2016-01-14 04:35:41 UTC) #33
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 11 months ago (2016-01-14 05:11:33 UTC) #35
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 05:13:22 UTC) #37
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/ac7237a24b28daa6f1c5292f32e940cc63fba39d
Cr-Commit-Position: refs/heads/master@{#369334}

Powered by Google App Engine
This is Rietveld 408576698