Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1580353003: [turbofan] Avoid using the typer's types in representation inference for phis. (Closed)

Created:
4 years, 11 months ago by Jarin
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Avoid using the typer's types in representation inference for phis. Once we use type feedback, we need to reflect the feedback in the types, propagate the new narrower types forward and use them in the subsequent representation inference. This CL propagates and uses the recomputed types for Phi and Select nodes (rather than using the types from the typer). Committed: https://crrev.com/ed21aa2449ec6991735158118ab6513723e3b784 Cr-Commit-Position: refs/heads/master@{#33268}

Patch Set 1 #

Patch Set 2 : Tweaks #

Patch Set 3 : Tweaks in comments #

Patch Set 4 : Remove dead code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -70 lines) Patch
M src/compiler/representation-change.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 3 5 chunks +69 lines, -67 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Jarin
Could you take a look, please?
4 years, 11 months ago (2016-01-13 13:39:47 UTC) #3
Benedikt Meurer
lgtm
4 years, 11 months ago (2016-01-13 14:51:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580353003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580353003/80001
4 years, 11 months ago (2016-01-13 14:54:44 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 11 months ago (2016-01-13 15:35:23 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 15:35:43 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ed21aa2449ec6991735158118ab6513723e3b784
Cr-Commit-Position: refs/heads/master@{#33268}

Powered by Google App Engine
This is Rietveld 408576698