Restrict GeneratePreagedPrologue to proper functions.

test/cctest/test-api-fast-accessor-builder.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdlib.h>
 
 #include "include/v8.h"
 #include "include/v8-experimental.h"
 
 #include "src/api.h"
@@ skipping 20 matching lines @@
 static void NativePropertyAccessor(
     const v8::FunctionCallbackInfo<v8::Value>& info) {
   info.GetReturnValue().Set(v8_num(123));
 }
 
 }  // anonymous namespace
 
 
 // Build a simple "fast accessor" and verify that it is being called.
 TEST(FastAccessor) {
-  if (i::FLAG_always_opt || i::FLAG_optimize_for_size) return;
+  if (i::FLAG_always_opt) return;
 
   LocalContext env;
   v8::Isolate* isolate = env->GetIsolate();
   v8::HandleScope scope(isolate);
 
   v8::Local<v8::FunctionTemplate> foo = v8::FunctionTemplate::New(isolate);
 
   // Native accessor, bar, returns 123.
   foo->PrototypeTemplate()->SetAccessorProperty(
       v8_str("bar"),
@@ skipping 29 matching lines @@
   builder->ReturnValue(
       builder->LoadInternalField(builder->GetReceiver(), field_no));
   templ->SetAccessorProperty(v8_str(name),
                              v8::FunctionTemplate::NewWithFastHandler(
                                  isolate, NativePropertyAccessor, builder));
 }
 
 
 // "Fast" accessor that accesses an internal field.
 TEST(FastAccessorWithInternalField) {
-  if (i::FLAG_always_opt || i::FLAG_optimize_for_size) return;
+  if (i::FLAG_always_opt) return;
 
   LocalContext env;
   v8::Isolate* isolate = env->GetIsolate();
   v8::HandleScope scope(isolate);
 
   v8::Local<v8::ObjectTemplate> foo = v8::ObjectTemplate::New(isolate);
   foo->SetInternalFieldCount(3);
   AddInternalFieldAccessor(isolate, foo, "field0", 0);
   AddInternalFieldAccessor(isolate, foo, "field1", 1);
   AddInternalFieldAccessor(isolate, foo, "field2", 2);
@@ skipping 11 matching lines @@
 
   // Access fields.
   ExpectString("field0()", "Hi there!");
   ExpectInt32("field1()", 4321);
   ExpectUndefined("field2()");
 }
 
 
 // "Fast" accessor with control flow via ...OrReturnNull methods.
 TEST(FastAccessorOrReturnNull) {
-  if (i::FLAG_always_opt || i::FLAG_optimize_for_size) return;
+  if (i::FLAG_always_opt) return;
 
   LocalContext env;
   v8::Isolate* isolate = env->GetIsolate();
   v8::HandleScope scope(isolate);
 
   v8::Local<v8::ObjectTemplate> foo = v8::ObjectTemplate::New(isolate);
   foo->SetInternalFieldCount(2);
   {
     // accessor "nullcheck": Return null if field 0 is non-null object; else 5.
     auto builder = v8::experimental::FastAccessorBuilder::New(isolate);
@@ skipping 32 matching lines @@
       "function maskcheck() { return obj.maskcheck }; " WARMUP("maskcheck()"));
   obj->SetAlignedPointerInInternalField(1, reinterpret_cast<void*>(0xf0));
   ExpectInt32("maskcheck()", 42);
   obj->SetAlignedPointerInInternalField(1, reinterpret_cast<void*>(0xfe));
   ExpectNull("maskcheck()");
 }
 
 
 // "Fast" accessor with simple control flow via explicit labels.
 TEST(FastAccessorControlFlowWithLabels) {
-  if (i::FLAG_always_opt || i::FLAG_optimize_for_size) return;
+  if (i::FLAG_always_opt) return;
 
   LocalContext env;
   v8::Isolate* isolate = env->GetIsolate();
   v8::HandleScope scope(isolate);
 
   v8::Local<v8::ObjectTemplate> foo = v8::ObjectTemplate::New(isolate);
   foo->SetInternalFieldCount(1);
   {
     // accessor isnull: 0 for nullptr, else 1.
     auto builder = v8::experimental::FastAccessorBuilder::New(isolate);
@@ skipping 16 matching lines @@
   CompileRun("function isnull() { return obj.isnull }; " WARMUP("isnull()"));
   obj->SetAlignedPointerInInternalField(0, /* anything != nullptr */ isolate);
   ExpectInt32("isnull()", 1);
   obj->SetAlignedPointerInInternalField(0, nullptr);
   ExpectInt32("isnull()", 0);
 }
 
 
 // "Fast" accessor, loading things.
 TEST(FastAccessorLoad) {
-  if (i::FLAG_always_opt || i::FLAG_optimize_for_size) return;
+  if (i::FLAG_always_opt) return;
 
   LocalContext env;
   v8::Isolate* isolate = env->GetIsolate();
   v8::HandleScope scope(isolate);
 
   v8::Local<v8::ObjectTemplate> foo = v8::ObjectTemplate::New(isolate);
   foo->SetInternalFieldCount(1);
 
   // Internal field 0 is a pointer to a C++ data structure that we wish to load
   // field values from.
@@ skipping 41 matching lines @@
   ExpectInt32("nonzero()", 1);
   val.intval = 0;
   ExpectInt32("nonzero()", 0);
   val.intval = 27;
   ExpectInt32("nonzero()", 1);
 
   // Access val.v8val:
   CompileRun("function loadval() { return obj.loadval }; " WARMUP("loadval()"));
   ExpectString("loadval()", "Hello");
 }