Restrict GeneratePreagedPrologue to proper functions.

test/cctest/heap/test-heap.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1549 matching lines @@
   }
 
   // On second compilation, the hash is replaced by a real cache entry mapping
   // the source to the shared function info containing the code.
   info = compilation_cache->LookupScript(
       source, Handle<Object>(), 0, 0,
       v8::ScriptOriginOptions(false, true, false), native_context,
       language_mode);
   CHECK(!info.is_null());
 
-  heap->CollectAllGarbage();
+  // Check that the code cache entry survives at least on GC.
+  // (Unless --optimize-for-size, in which case it might get collected
+  // immediately.)
+  if (!FLAG_optimize_for_size) {
+    heap->CollectAllGarbage();
+    info = compilation_cache->LookupScript(
+        source, Handle<Object>(), 0, 0,
+        v8::ScriptOriginOptions(false, true, false), native_context,
+        language_mode);
+    CHECK(!info.is_null());
+  }
 
-  // On second compilation, the hash is replaced by a real cache entry mapping
-  // the source to the shared function info containing the code.
-  info = compilation_cache->LookupScript(
-      source, Handle<Object>(), 0, 0,
-      v8::ScriptOriginOptions(false, true, false), native_context,
-      language_mode);
-  CHECK(!info.is_null());
-
+  // Progress code age until it's old and ready for GC.
   while (!info.ToHandleChecked()->code()->IsOld()) {
-    info.ToHandleChecked()->code()->MakeOlder(NO_MARKING_PARITY);
+    // To guarantee progress, we have to MakeOlder with different parities.
+    // We can't just use NO_MARKING_PARITY, since e.g. kExecutedOnceCodeAge is
+    // always NO_MARKING_PARITY and the code age only progresses if the parity
+    // is different.
+    info.ToHandleChecked()->code()->MakeOlder(ODD_MARKING_PARITY);
+    info.ToHandleChecked()->code()->MakeOlder(EVEN_MARKING_PARITY);
   }
 
   heap->CollectAllGarbage();
   // Ensure code aging cleared the entry from the cache.
   info = compilation_cache->LookupScript(
       source, Handle<Object>(), 0, 0,
       v8::ScriptOriginOptions(false, true, false), native_context,
       language_mode);
   CHECK(info.is_null());
 
@@ skipping 4866 matching lines @@
   isolate->IncrementJsCallsFromApiCounter();
   isolate->IncrementJsCallsFromApiCounter();
   isolate->IncrementJsCallsFromApiCounter();
   calls_per_ms = memory_reducer->SampleAndGetJsCallsPerMs(4);
   CheckDoubleEquals(2, calls_per_ms);
 }
 
 
 }  // namespace internal
 }  // namespace v8