Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: tools/perf/core/stacktrace_unittest.py

Issue 1580313002: Revert of Added unit test for stack traces in telemetry crashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/exceptions.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/core/stacktrace_unittest.py
diff --git a/tools/perf/core/stacktrace_unittest.py b/tools/perf/core/stacktrace_unittest.py
deleted file mode 100644
index be13fbaad9be3ad7d2ed32759af214dd7b705619..0000000000000000000000000000000000000000
--- a/tools/perf/core/stacktrace_unittest.py
+++ /dev/null
@@ -1,27 +0,0 @@
-# Copyright 2015 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-from telemetry.core import exceptions
-from telemetry import decorators
-from telemetry.testing import tab_test_case
-
-class TabStackTraceTest(tab_test_case.TabTestCase):
-
- # For now just work on a single platform (mac).
- @decorators.Enabled('mac')
- def testStackTrace(self):
- try:
- self._tab.Navigate('chrome://crash', timeout=5)
- except exceptions.DevtoolsTargetCrashException as e:
- self.assertIn('Thread 0 (crashed)', '\n'.join(e.stack_trace))
-
- # Currently stack traces do not work on windows: http://crbug.com/476110
- # Currently symbols do not work on swarming: http://crbug.com/563716
- # Linux stack traces depends on fission support: http://crbug.com/405623
- @decorators.Disabled('all')
- def testCrashSymbols(self):
- try:
- self._tab.Navigate('chrome://crash', timeout=5)
- except exceptions.DevtoolsTargetCrashException as e:
- self.assertIn('CrashIntentionally', '\n'.join(e.stack_trace))
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/exceptions.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698