Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1580313002: Revert of Added unit test for stack traces in telemetry crashes. (Closed)

Created:
4 years, 11 months ago by David Yen
Modified:
4 years, 11 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Added unit test for stack traces in telemetry crashes. (patchset #17 id:320001 of https://codereview.chromium.org/1498633003/ ) Reason for revert: Test fails on some bots. Original issue's description: > Added unit test for stack traces in telemetry crashes. > > This CL also fixes an issue on Mac where telemetry does not > know how to locate chromium_framework for the symbols. > > R=nednguyen@google.com > BUG=563716 > TEST=ran unit test locally > > Committed: https://crrev.com/a20e03ee6906c50bdfaf8fb34fe684b4a89db852 > Cr-Commit-Position: refs/heads/master@{#368997} TBR=nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=563716 Committed: https://crrev.com/f0cb0bf2dd7f677423318d2318902311e635538d Cr-Commit-Position: refs/heads/master@{#369056}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -50 lines) Patch
D tools/perf/core/stacktrace_unittest.py View 1 chunk +0 lines, -27 lines 0 comments Download
M tools/telemetry/telemetry/core/exceptions.py View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py View 2 chunks +1 line, -19 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
David Yen
Created Revert of Added unit test for stack traces in telemetry crashes.
4 years, 11 months ago (2016-01-13 00:49:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580313002/1
4 years, 11 months ago (2016-01-13 00:51:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-13 00:53:13 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f0cb0bf2dd7f677423318d2318902311e635538d Cr-Commit-Position: refs/heads/master@{#369056}
4 years, 11 months ago (2016-01-13 00:54:16 UTC) #5
David Yen
4 years, 11 months ago (2016-01-13 22:01:12 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1581143002/ by dyen@chromium.org.

The reason for reverting is: Try again disabling 10.6.

Powered by Google App Engine
This is Rietveld 408576698