third_party/WebKit/Source/core/svg/SVGLength.h - Issue 1580293008: Fix incorrect handling of small non-percentage value for 'startOffset' on <textPath>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGLength.h

Issue 1580293008: Fix incorrect handling of small non-percentage value for 'startOffset' on <textPath> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp ('K') | « third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGLength.h

diff --git a/third_party/WebKit/Source/core/svg/SVGLength.h b/third_party/WebKit/Source/core/svg/SVGLength.h

index 20f9c50f7a0d7933678007a45baee9d15bd518df..5c5767d4fa6a40a302a05f161a13f40e46a56dd7 100644

--- a/third_party/WebKit/Source/core/svg/SVGLength.h

+++ b/third_party/WebKit/Source/core/svg/SVGLength.h

@@ -91,6 +91,7 @@ public:

|| (unitType >= CSSPrimitiveValue::UnitType::ViewportWidth && unitType <= CSSPrimitiveValue::UnitType::ViewportMax);

}

inline bool isRelative() const { return isRelativeUnit(m_value->typeWithCalcResolved()); }

+ inline bool isPercentage() const { return m_value->typeWithCalcResolved() == CSSPrimitiveValue::UnitType::Percentage; }

fs 2016/01/28 14:00:20 Just use typeWithCalcResolved directly.

bool isZero() const

{

« third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp ('K') | « third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp ('k') | no next file » | no next file with comments »