Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1580293003:
NaCl: Update revision in DEPS, 26c7e6a -> c4c237c (Closed)
|
Created:
4 years, 11 months ago by Mark Seaborn Modified:
4 years, 11 months ago Reviewers:
Roland McGrath CC:
chromium-reviews, erikchen, Roland McGrath, Mark Seaborn, native-client-reviews_googlegroups.com, petarj, Jim Stichnoth, Nico Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionNaCl: Update revision in DEPS, 26c7e6a -> c4c237c
This pulls in the following Native Client changes:
95163bf: (stichnot@chromium.org) Update revision for PNaCl
abee7c9: (petarj@mips.com) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS
b44e8dc: (petarj@mips.com) [MIPS] Make $t8 point to the address of TLS pointers
11ff949: (thakis@chromium.org) clang/win: Fix -Wsign-compare warning in platform_impl.cc
f39aa44: (mseaborn@chromium.org) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS: add ConvertToPSO
aebc3c4: (mcgrathr@chromium.org) Update chrome_rev
c4c237c: (erikchen@chromium.org) Back dynamic text regions with a Mach memory region.
Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/26c7e6ae1327a43c948f4666fef9e84fe351ab7c..c4c237c0567cbe1c7de664a4d81673c3403cf55b
BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
Committed: https://crrev.com/97c9eecf2e7a5857d6dc6ddb22eb27251f9eefc4
Cr-Commit-Position: refs/heads/master@{#369294}
Patch Set 1 #Messages
Total messages: 18 (9 generated)
Description was changed from ========== NaCl: Update revision in DEPS, 26c7e6a -> c4c237c This pulls in the following Native Client changes: 95163bf: (stichnot@chromium.org) Update revision for PNaCl abee7c9: (petarj@mips.com) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS b44e8dc: (petarj@mips.com) [MIPS] Make $t8 point to the address of TLS pointers 11ff949: (thakis@chromium.org) clang/win: Fix -Wsign-compare warning in platform_impl.cc f39aa44: (mseaborn@chromium.org) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS: add ConvertToPSO aebc3c4: (mcgrathr@chromium.org) Update chrome_rev c4c237c: (erikchen@chromium.org) Back dynamic text regions with a Mach memory region. Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/26c7e6... BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build ========== to ========== NaCl: Update revision in DEPS, 26c7e6a -> c4c237c This pulls in the following Native Client changes: 95163bf: (stichnot@chromium.org) Update revision for PNaCl abee7c9: (petarj@mips.com) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS b44e8dc: (petarj@mips.com) [MIPS] Make $t8 point to the address of TLS pointers 11ff949: (thakis@chromium.org) clang/win: Fix -Wsign-compare warning in platform_impl.cc f39aa44: (mseaborn@chromium.org) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS: add ConvertToPSO aebc3c4: (mcgrathr@chromium.org) Update chrome_rev c4c237c: (erikchen@chromium.org) Back dynamic text regions with a Mach memory region. Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/26c7e6... BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build ==========
mseaborn@chromium.org changed reviewers: + mcgrathr@chromium.org
The CQ bit was checked by mseaborn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580293003/1
lgtm
The CQ bit was unchecked by mseaborn@chromium.org
The CQ bit was checked by mseaborn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580293003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_clang_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) cast_shell_android on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) linux_android_rel_ng on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) cast_shell_linux on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by mseaborn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580293003/1
Message was sent while issue was closed.
Description was changed from ========== NaCl: Update revision in DEPS, 26c7e6a -> c4c237c This pulls in the following Native Client changes: 95163bf: (stichnot@chromium.org) Update revision for PNaCl abee7c9: (petarj@mips.com) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS b44e8dc: (petarj@mips.com) [MIPS] Make $t8 point to the address of TLS pointers 11ff949: (thakis@chromium.org) clang/win: Fix -Wsign-compare warning in platform_impl.cc f39aa44: (mseaborn@chromium.org) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS: add ConvertToPSO aebc3c4: (mcgrathr@chromium.org) Update chrome_rev c4c237c: (erikchen@chromium.org) Back dynamic text regions with a Mach memory region. Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/26c7e6... BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build ========== to ========== NaCl: Update revision in DEPS, 26c7e6a -> c4c237c This pulls in the following Native Client changes: 95163bf: (stichnot@chromium.org) Update revision for PNaCl abee7c9: (petarj@mips.com) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS b44e8dc: (petarj@mips.com) [MIPS] Make $t8 point to the address of TLS pointers 11ff949: (thakis@chromium.org) clang/win: Fix -Wsign-compare warning in platform_impl.cc f39aa44: (mseaborn@chromium.org) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS: add ConvertToPSO aebc3c4: (mcgrathr@chromium.org) Update chrome_rev c4c237c: (erikchen@chromium.org) Back dynamic text regions with a Mach memory region. Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/26c7e6... BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== NaCl: Update revision in DEPS, 26c7e6a -> c4c237c This pulls in the following Native Client changes: 95163bf: (stichnot@chromium.org) Update revision for PNaCl abee7c9: (petarj@mips.com) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS b44e8dc: (petarj@mips.com) [MIPS] Make $t8 point to the address of TLS pointers 11ff949: (thakis@chromium.org) clang/win: Fix -Wsign-compare warning in platform_impl.cc f39aa44: (mseaborn@chromium.org) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS: add ConvertToPSO aebc3c4: (mcgrathr@chromium.org) Update chrome_rev c4c237c: (erikchen@chromium.org) Back dynamic text regions with a Mach memory region. Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/26c7e6... BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build ========== to ========== NaCl: Update revision in DEPS, 26c7e6a -> c4c237c This pulls in the following Native Client changes: 95163bf: (stichnot@chromium.org) Update revision for PNaCl abee7c9: (petarj@mips.com) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS b44e8dc: (petarj@mips.com) [MIPS] Make $t8 point to the address of TLS pointers 11ff949: (thakis@chromium.org) clang/win: Fix -Wsign-compare warning in platform_impl.cc f39aa44: (mseaborn@chromium.org) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS: add ConvertToPSO aebc3c4: (mcgrathr@chromium.org) Update chrome_rev c4c237c: (erikchen@chromium.org) Back dynamic text regions with a Mach memory region. Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/26c7e6... BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build Committed: https://crrev.com/97c9eecf2e7a5857d6dc6ddb22eb27251f9eefc4 Cr-Commit-Position: refs/heads/master@{#369294} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/97c9eecf2e7a5857d6dc6ddb22eb27251f9eefc4 Cr-Commit-Position: refs/heads/master@{#369294}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1586683003/ by vasilii@chromium.org. The reason for reverting is: Broke nacl_integration on Mac10.6 Tests. https://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/10932 dyld: Library not loaded: /usr/lib/libc++.1.dylib Referenced from: /Volumes/data/b/build/slave/Mac10_6_Tests/build/src/native_client/toolchain/mac_x86/pnacl_newlib/bin/x86_64-nacl-clang Reason: image not found /Volumes/data/b/build/slave/Mac10_6_Tests/build/src/native_client/toolchain/mac_x86/pnacl_newlib/bin/x86_64-nacl-clang -m64 -std=gnu99 -O2 -g -fomit-frame-pointer -fasynchronous-unwind-tables -Wall -Wundef -fdiagnostics-show-option -Werror -Wno-variadic-macros -Wno-language-extension-token -integrated-as -D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1 -D_GNU_SOURCE=1 -D_POSIX_C_SOURCE=199506 -D_XOPEN_SOURCE=600 -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DDYNAMIC_ANNOTATIONS_PREFIX=NACL_ -DNACL_BUILD_ARCH=x86 -DNACL_BUILD_SUBARCH=64 -Iscons-out/nacl-x86-64/include -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/ppapi/native_client/scons-out/nacl-x86-64/include -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src -I/Volumes/data/b/build/slave/Mac10_6_Tests/build/src/ppapi -c -o scons-out/nacl-x86-64/obj/src/untrusted/nacl/stubs/socket.o src/untrusted/nacl/stubs/socket.c scons: *** [scons-out/nacl-x86-64/obj/src/untrusted/nacl/sigprocmask.o] Error -5 ... scons-out/nacl-x86-64/obj/src/untrusted/nacl/sigprocmask.o failed: Error -5 And many similar messages . |
