google_apis/gcm/engine/registration_request.cc - Issue 158023007: Add GCM check in status code metric collection. We also decided to collect registration success sig…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/engine/registration_request.cc

Issue 158023007: Add GCM check in status code metric collection. We also decided to collect registration success sig… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« google_apis/gcm/engine/checkin_request.cc ('K') | « google_apis/gcm/engine/checkin_request.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: google_apis/gcm/engine/registration_request.cc

diff --git a/google_apis/gcm/engine/registration_request.cc b/google_apis/gcm/engine/registration_request.cc

index 5635e5e62fdf9108facfc3636c4b8ad576ca2eb3..2880855110bf08053f7f7c7eb2cb3cdeb9fbc037 100644

--- a/google_apis/gcm/engine/registration_request.cc

+++ b/google_apis/gcm/engine/registration_request.cc

@@ -203,6 +203,8 @@ void RegistrationRequest::OnURLFetchComplete(const net::URLFetcher* source) {

if (token_pos != std::string::npos) {

std::string token =

response.substr(token_pos + arraysize(kTokenPrefix) - 1);

+ UMA_HISTOGRAM_ENUMERATION("GCM.RegistrationRequestStatus", SUCCESS,

+ RegistrationRequest::STATUS_COUNT);

callback_.Run(SUCCESS, token);

return;

}