Add GCM check in status code metric collection. We also decided to collect registration success sig…

google_apis/gcm/engine/registration_request.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "google_apis/gcm/engine/registration_request.h"
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 185 matching lines @@
                << source->GetResponseCode();
     RetryWithBackoff(true);
     return;
   }
 
   DVLOG(1) << "Parsing registration response: " << response;
   size_t token_pos = response.find(kTokenPrefix);
   if (token_pos != std::string::npos) {
     std::string token =
         response.substr(token_pos + arraysize(kTokenPrefix) - 1);
+    UMA_HISTOGRAM_ENUMERATION("GCM.RegistrationRequestStatus", SUCCESS,

[jianli, 2014/02/12 18:41:05]

nit: define a helper function as you did in CheckinRequest

[juyik, 2014/02/12 18:55:20]

Done.

+                              RegistrationRequest::STATUS_COUNT);
     callback_.Run(SUCCESS, token);
     return;
   }
 
   size_t error_pos = response.find(kErrorPrefix);
   Status status = UNKNOWN_ERROR;
   if (error_pos != std::string::npos) {
     std::string error =
         response.substr(error_pos + arraysize(kErrorPrefix) - 1);
     status = GetStatusFromError(error);
   }
   UMA_HISTOGRAM_ENUMERATION("GCM.RegistrationRequestStatus", status,
                             RegistrationRequest::STATUS_COUNT);
 
   if (ShouldRetryWithStatus(status)) {
     RetryWithBackoff(true);
     return;
   }
 
   callback_.Run(status, std::string());
 }
 
 }  // namespace gcm