Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1580193002: mus: Do not notify clients when the roots are reordered. (Closed)

Created:
4 years, 11 months ago by sadrul
Modified:
4 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Do not notify clients when the roots are reordered. BUG=none Committed: https://crrev.com/04a9cf00d60912dde3e6fe4caa66b205d14acb68 Cr-Commit-Position: refs/heads/master@{#369098}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M components/mus/public/cpp/lib/window.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/ws/window_tree_impl.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sadrul
No new tests: I am thinking the existing tests and the DCHECK()s provide sufficient test ...
4 years, 11 months ago (2016-01-12 21:50:13 UTC) #2
sky
LGTM with a better comment https://codereview.chromium.org/1580193002/diff/1/components/mus/ws/window_tree_impl.cc File components/mus/ws/window_tree_impl.cc (right): https://codereview.chromium.org/1580193002/diff/1/components/mus/ws/window_tree_impl.cc#newcode418 components/mus/ws/window_tree_impl.cc:418: // Do not notify ...
4 years, 11 months ago (2016-01-12 22:36:08 UTC) #3
sadrul
https://codereview.chromium.org/1580193002/diff/1/components/mus/ws/window_tree_impl.cc File components/mus/ws/window_tree_impl.cc (right): https://codereview.chromium.org/1580193002/diff/1/components/mus/ws/window_tree_impl.cc#newcode418 components/mus/ws/window_tree_impl.cc:418: // Do not notify ordering changes of the root ...
4 years, 11 months ago (2016-01-13 02:26:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580193002/20001
4 years, 11 months ago (2016-01-13 02:28:31 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-13 03:47:16 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 03:48:02 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/04a9cf00d60912dde3e6fe4caa66b205d14acb68
Cr-Commit-Position: refs/heads/master@{#369098}

Powered by Google App Engine
This is Rietveld 408576698