Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1580183002: arc-bridge: Fix deps in chrome/browser/ui/app_list/arc (Closed)

Created:
4 years, 11 months ago by Luis Héctor Chávez
Modified:
4 years, 11 months ago
Reviewers:
xiyuan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc-bridge: Fix deps in chrome/browser/ui/app_list/arc It turns out that we were under-specifying the dependencies in that directory, so if the .mojom files in components/arc/common change, this might trigger a compilation error. BUG=None TEST=ninja -C out/Release -t commands \ obj/chrome/browser/ui/app_list/arc/browser_ui.arc_app_item.o | \ grep mojom_bindings_generator.*arc/common Committed: https://crrev.com/b89916f197022e3d94468f6d9eaece95dbf28ac4 Cr-Commit-Position: refs/heads/master@{#371812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/chrome_browser_ui.gypi View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Luis Héctor Chávez
PTAL
4 years, 11 months ago (2016-01-12 21:40:57 UTC) #2
Luis Héctor Chávez
ping?
4 years, 11 months ago (2016-01-27 00:19:40 UTC) #3
xiyuan
lgtm Sorry for the delay. Somehow, it dropped out of my radar.
4 years, 11 months ago (2016-01-27 16:50:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580183002/1
4 years, 11 months ago (2016-01-27 16:51:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 17:35:22 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 17:36:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b89916f197022e3d94468f6d9eaece95dbf28ac4
Cr-Commit-Position: refs/heads/master@{#371812}

Powered by Google App Engine
This is Rietveld 408576698