IDL parser rewrite in Python

Source/bindings/scripts/idl_compiler.py

 #!/usr/bin/python
 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
@@ skipping 23 matching lines @@
 [1] Perl: deprecated_generate_bindings.pl, which calls:
     deprecated_idl_parser.pm => deprecated_code_generator_v8.pm
 [2] Python: idl_compiler.py, which calls:
     IDL lexer => IDL parser => Python object builder =>
     interface dependency resolver => IDL semantic validator =>
     C++ code generator
 
 We will move IDL files from the Perl build flow [1] to the Python build flow [2]
 incrementally. See http://crbug.com/239771
 """
+import pickle

[haraken, 2013/07/16 14:17:51]

Nit: alphabetical order please.

[Nils Barth (inactive), 2013/07/17 12:05:09]

Oops, fixed.

 import optparse
 import os
 import shlex
 import sys
 
+import code_generator_v8
 import idl_reader
-import code_generator_v8
 
 
 def parse_options():
     parser = optparse.OptionParser()
     parser.add_option('--additional-idl-files')
+    parser.add_option('--dump-json-and-pickle', action='store_true', default=False)
     parser.add_option('--idl-attributes-file')
     parser.add_option('--include', dest='idl_directories', action='append')
     parser.add_option('--output-directory')
     parser.add_option('--interface-dependencies-file')
     parser.add_option('--verbose', action='store_true', default=False)
     parser.add_option('--write-file-only-if-changed', type='int')
     # ensure output comes last, so command line easy to parse via regexes
     parser.disable_interspersed_args()
 
     options, args = parser.parse_args()
     if options.output_directory is None:
         parser.error('Must specify output directory using --output-directory.')
     if options.additional_idl_files is not None:
         # additional_idl_files is passed as a string with varied (shell-style)
         # quoting, hence needs parsing.
         options.additional_idl_files = shlex.split(options.additional_idl_files)
     if len(args) != 1:
         parser.error('Must specify exactly 1 input file as argument, but %d given.' % len(args))
     options.idl_filename = os.path.realpath(args[0])
     return options
 
 
+def write_json_and_pickle(definitions, interface_name, output_directory):

[haraken, 2013/07/16 14:17:51]

I'm OK with leaving this option until you finish moving everything. But please
add a FIXME about it.

[Nils Barth (inactive), 2013/07/17 12:05:09]

(As above.) Done.

+    json_string = definitions.to_json()
+    json_basename = interface_name + '.json'
+    json_filename = os.path.join(output_directory, json_basename)
+    with open(json_filename, 'w') as json_file:
+        json_file.write(json_string)
+    # Pickle export (for Koji)

[haraken, 2013/07/16 14:17:51]

Nit: Remove this comment.

[Nils Barth (inactive), 2013/07/17 12:05:09]

Done.

+    pickle_basename = interface_name + '.pkl'
+    pickle_filename = os.path.join(output_directory, pickle_basename)
+    with open(pickle_filename, 'wb') as pickle_file:
+        pickle.dump(definitions, pickle_file)
+
+
 def main():
     options = parse_options()
     idl_filename = options.idl_filename
     basename = os.path.basename(idl_filename)
     interface_name, _ = os.path.splitext(basename)
     verbose = options.verbose
     if verbose:
         print idl_filename
 
-    idl_definitions = idl_reader.read_idl_definitions(idl_filename, options.interface_dependencies_file, options.additional_idl_files)
-    # FIXME: add parameters when add validator
-    # idl_definitions = idl_reader.read_idl_interface(idl_filename, options.interface_dependencies_file, options.additional_idl_files, options.idl_attributes_file, verbose=verbose)
-    if not idl_definitions:
+    definitions = idl_reader.read_idl_definitions(idl_filename, options.interface_dependencies_file, options.additional_idl_files, options.idl_attributes_file, verbose=options.verbose)
+    if not definitions:
         # We generate dummy .h and .cpp files just to tell build scripts
         # that outputs have been created.
         code_generator_v8.generate_dummy_header_and_cpp(interface_name, options.output_directory)
         return
+    if options.dump_json_and_pickle:
+        write_json_and_pickle(definitions, interface_name, options.output_directory)
+        return
     # FIXME: turn on code generator
-    # Currently idl_definitions must be None (so dummy .h and .cpp files are
-    # generated), as actual code generator not present yet.
-    # code_generator_v8.write_interface(idl_definitions, interface_name, options.output_directory)
+    # Currently definitions must be None (so dummy .h and .cpp files are
+    # generated), or --dump-json-and-pickle selected, as actual code generator
+    # not present yet.
+    # code_generator_v8.write_interface(definitions, interface_name, options.output_directory)
     raise RuntimeError('Stub: code generator not implemented yet')
 
 
 if __name__ == '__main__':
     sys.exit(main())