Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1580033004: exo: Improve Maximize and Fullscreen support for ShellSurfaces. (Closed)

Created:
4 years, 11 months ago by reveman
Modified:
4 years, 11 months ago
Reviewers:
lpique
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Improve Maximize and Fullscreen support for ShellSurfaces. This allows Maximize and Fullscreen functions to be used dynamically and introduces a configure callback that allows clients to know what the suggested size of the surface is after the shell surface has entered one of these states. BUG=549781 TEST=exo_unittest --gtest_filter=ShellSurfaceTest.* Committed: https://crrev.com/2598cfd981ca64f064884d3476bc01035f97b854 Cr-Commit-Position: refs/heads/master@{#369265}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -93 lines) Patch
M components/exo/keyboard_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/exo/pointer_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M components/exo/shell_surface.h View 2 chunks +16 lines, -6 lines 0 comments Download
M components/exo/shell_surface.cc View 3 chunks +25 lines, -49 lines 0 comments Download
M components/exo/shell_surface_unittest.cc View 10 chunks +35 lines, -12 lines 0 comments Download
M components/exo/touch_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M components/exo/wayland/server.cc View 1 11 chunks +40 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
reveman
4 years, 11 months ago (2016-01-13 00:12:00 UTC) #2
lpique
lgtm https://codereview.chromium.org/1580033004/diff/1/components/exo/wayland/server.cc File components/exo/wayland/server.cc (right): https://codereview.chromium.org/1580033004/diff/1/components/exo/wayland/server.cc#newcode930 components/exo/wayland/server.cc:930: wl_array_init(&states); nit: Please at least add a TODO ...
4 years, 11 months ago (2016-01-13 19:22:39 UTC) #3
reveman
https://codereview.chromium.org/1580033004/diff/1/components/exo/wayland/server.cc File components/exo/wayland/server.cc (right): https://codereview.chromium.org/1580033004/diff/1/components/exo/wayland/server.cc#newcode930 components/exo/wayland/server.cc:930: wl_array_init(&states); On 2016/01/13 at 19:22:39, lpique wrote: > nit: ...
4 years, 11 months ago (2016-01-13 19:39:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580033004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580033004/20001
4 years, 11 months ago (2016-01-13 19:40:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-13 20:45:26 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 20:47:06 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2598cfd981ca64f064884d3476bc01035f97b854
Cr-Commit-Position: refs/heads/master@{#369265}

Powered by Google App Engine
This is Rietveld 408576698