Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Issue 1580013003: Test dependency tracking of unused imports/exports. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Test dependency tracking of unused imports/exports. If library A imports or exports library B (either directly or via an export), library B needs to be included in the dependency list for library A's prelinked summary, since a change to library B might change the meaning of a name which *is* used by library A. Note that two of the new tests are currently failing, due to the fact that we aren't tracking dependencies that only affect the export namespace. That will be fixed in a future CL. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/35f3961ea6e8cb3e82bee31b17ec1ec331ad8dab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M pkg/analyzer/test/src/summary/summary_test.dart View 3 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-12 20:07:08 UTC) #2
scheglov
LGTM
4 years, 11 months ago (2016-01-12 20:10:09 UTC) #3
Paul Berry
4 years, 11 months ago (2016-01-13 16:17:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
35f3961ea6e8cb3e82bee31b17ec1ec331ad8dab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698