Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: core/src/fxge/ge/fx_ge_font.cpp

Issue 1579883002: Fix memory leakage on Linux - part2 (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/src/fxge/ge/fx_ge_font.cpp
diff --git a/core/src/fxge/ge/fx_ge_font.cpp b/core/src/fxge/ge/fx_ge_font.cpp
index 4c0cef40c43a41fe0ef9ba122c42668dd0dfcea4..56e178f985ed19cf8b306776701a851c7fc2b66d 100644
--- a/core/src/fxge/ge/fx_ge_font.cpp
+++ b/core/src/fxge/ge/fx_ge_font.cpp
@@ -106,11 +106,8 @@ FX_BOOL CFX_Font::LoadClone(const CFX_Font* pFont) {
CFX_Font::~CFX_Font() {
delete m_pSubstFont;
- m_pSubstFont = NULL;
-#ifndef PDF_ENABLE_XFA
FX_Free(m_pFontDataAllocation);
- m_pFontDataAllocation = NULL;
-#else
+#ifdef PDF_ENABLE_XFA
if (m_bLogic) {
m_OtfFontData.DetachBuffer();
return;
@@ -130,10 +127,8 @@ CFX_Font::~CFX_Font() {
}
#ifdef PDF_ENABLE_XFA
FX_Free(m_pOwnedStream);
- m_pOwnedStream = NULL;
#endif // PDF_ENABLE_XFA
FX_Free(m_pGsubData);
- m_pGsubData = NULL;
#if _FXM_PLATFORM_ == _FXM_PLATFORM_APPLE_
ReleasePlatformResource();
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698