Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1579853002: Add dscache.AlwaysFilterRDS function. (Closed)

Created:
4 years, 11 months ago by Vadim Sh.
Modified:
4 years, 11 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Add dscache.AlwaysFilterRDS function. It's like dscache.FilterRDS, except it doesn't use IsGloballyEnabled. Intended to be used by callers that know better when to apply (or not) the filter. R=iannucci@chromium.org BUG= Committed: https://github.com/luci/gae/commit/f8f0b39b483531e3c4a6cdef6693026676726f7c

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M filter/dscache/context.go View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Vadim Sh.
Adding any sort of hook would be ridiculous considering how IsGloballyEnabled is called...
4 years, 11 months ago (2016-01-12 03:08:15 UTC) #1
iannucci
lgtm https://codereview.chromium.org/1579853002/diff/1/filter/dscache/context.go File filter/dscache/context.go (right): https://codereview.chromium.org/1579853002/diff/1/filter/dscache/context.go#newcode30 filter/dscache/context.go:30: // If shardsForKey is nil, the value of ...
4 years, 11 months ago (2016-01-12 19:11:01 UTC) #2
Vadim Sh.
https://codereview.chromium.org/1579853002/diff/1/filter/dscache/context.go File filter/dscache/context.go (right): https://codereview.chromium.org/1579853002/diff/1/filter/dscache/context.go#newcode30 filter/dscache/context.go:30: // If shardsForKey is nil, the value of DefaultShards ...
4 years, 11 months ago (2016-01-12 19:16:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579853002/20001
4 years, 11 months ago (2016-01-12 19:16:41 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 19:19:01 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/f8f0b39b483531e3c4a6cdef6693026676726f7c

Powered by Google App Engine
This is Rietveld 408576698