Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2493)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpDirectoryObserver.java

Issue 1579723002: Add a file observer to monitor if there is a crash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: call "start watching" static method instead of calling the startWatching method from an instance Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpDirectoryObserver.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpDirectoryObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpDirectoryObserver.java
new file mode 100644
index 0000000000000000000000000000000000000000..1ad73722c5a4ef6b1339b87b4d4f514c971e8139
--- /dev/null
+++ b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpDirectoryObserver.java
@@ -0,0 +1,57 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.crash;
+
+import android.content.Context;
+import android.content.Intent;
+import android.os.FileObserver;
+
+import org.chromium.base.ApplicationStatus;
+import org.chromium.base.Log;
+import org.chromium.base.ThreadUtils;
+import org.chromium.base.metrics.RecordUserAction;
+
+import java.io.File;
+
+/**
+ * This class is a singleton that holds utilities for observer to monitor the minidump directory.
+ */
+public final class MinidumpDirectoryObserver extends FileObserver {
+
+ private static final String TAG = "MinidumpDirObserver";
+
+ private static MinidumpDirectoryObserver sMinidumpDirectoryObserver;
+ private static Context sContext = ApplicationStatus.getApplicationContext();
+
+ public static final String MINIDUMP_EXPERIMENT_NAME = "AddMinidumpDirObserver";
+
+ public static void startObserverWatching() {
+ ThreadUtils.assertOnUiThread();
+ if (sMinidumpDirectoryObserver == null) {
+ sMinidumpDirectoryObserver = new MinidumpDirectoryObserver();
+ }
+ sMinidumpDirectoryObserver.startWatching();
+ }
+
+ private MinidumpDirectoryObserver() {
+ // The file observer detects MOVED_TO for renderer crash and GPU crash;
no sievers 2016/01/29 23:52:34 nit: I'd just say 'child processes'. There's also
Menglin 2016/01/30 00:29:11 Done.
+ // it detects CREATE for browser crash
+ super(new File(sContext.getCacheDir(), CrashFileManager.CRASH_DUMP_DIR).toString(),
+ FileObserver.MOVED_TO);
+ }
+
+ /**
+ * When a miniudump is detected, upload it to Google crash server
+ */
+ @Override
+ public void onEvent(int event, String path) {
no sievers 2016/01/29 23:52:34 nit: Can you put a comment that this is happening
Menglin 2016/01/30 00:29:11 Done.
+ if (CrashFileManager.isMinidumpMIMEFirstTry(path)) {
+ Intent intent = MinidumpUploadService.createFindAndUploadLastCrashIntent(sContext);
+ sContext.startService(intent);
+ Log.i(TAG, "Detects a new minidump %s sending intent to MinidumpUploadService", path);
+ RecordUserAction.record("MobileBreakpadUploadAttempt");
no sievers 2016/01/29 23:52:34 This stat is still a bit broken, since the name su
Menglin 2016/01/30 00:29:12 I will leave it as it is for now and fix that in a
+ }
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698