Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1579713003:
Remove slow expectations for some text tests on Mac (Closed)
|
Created:
4 years, 11 months ago by Kunihiko Sakamoto Modified:
4 years, 11 months ago Reviewers:
drott CC:
chromium-reviews, blink-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove slow expectations for some text tests on Mac
Recovered by HarfBuzz roll (r368678).
BUG=547912
TBR=drott@chromium.org
Committed: https://crrev.com/e298422521a829f4b351d91341a2996e88188a40
Cr-Commit-Position: refs/heads/master@{#368846}
Patch Set 1 #
Messages
Total messages: 19 (10 generated)
Description was changed from ========== Remove slow expectations BUG= ========== to ========== Remove slow expectations for some text tests on Mac Recovered by HarfBuzz roll (r368678). ==========
Description was changed from ========== Remove slow expectations for some text tests on Mac Recovered by HarfBuzz roll (r368678). ========== to ========== Remove slow expectations for some text tests on Mac Recovered by HarfBuzz roll (r368678). BUG=547912 ==========
ksakamoto@chromium.org changed reviewers: + drott@chromium.org
Nice, thx!
The CQ bit was checked by ksakamoto@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579713003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579713003/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Oops, lgtm please :)
Description was changed from ========== Remove slow expectations for some text tests on Mac Recovered by HarfBuzz roll (r368678). BUG=547912 ========== to ========== Remove slow expectations for some text tests on Mac Recovered by HarfBuzz roll (r368678). BUG=547912 TBR=drott ==========
Description was changed from ========== Remove slow expectations for some text tests on Mac Recovered by HarfBuzz roll (r368678). BUG=547912 TBR=drott ========== to ========== Remove slow expectations for some text tests on Mac Recovered by HarfBuzz roll (r368678). BUG=547912 TBR=drott@chromium.org ==========
On 2016/01/12 08:36:57, Kunihiko Sakamoto wrote: > Oops, lgtm please :) Submitting with TBR.
The CQ bit was checked by ksakamoto@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579713003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579713003/1
Message was sent while issue was closed.
Description was changed from ========== Remove slow expectations for some text tests on Mac Recovered by HarfBuzz roll (r368678). BUG=547912 TBR=drott@chromium.org ========== to ========== Remove slow expectations for some text tests on Mac Recovered by HarfBuzz roll (r368678). BUG=547912 TBR=drott@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove slow expectations for some text tests on Mac Recovered by HarfBuzz roll (r368678). BUG=547912 TBR=drott@chromium.org ========== to ========== Remove slow expectations for some text tests on Mac Recovered by HarfBuzz roll (r368678). BUG=547912 TBR=drott@chromium.org Committed: https://crrev.com/e298422521a829f4b351d91341a2996e88188a40 Cr-Commit-Position: refs/heads/master@{#368846} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e298422521a829f4b351d91341a2996e88188a40 Cr-Commit-Position: refs/heads/master@{#368846} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
