Fix leak in WeakPtrTest::NonOwnerThreadCanCopyAndAssignWeakPtr{,Base}

Fix leak in WeakPtrTest::NonOwnerThreadCanCopyAndAssignWeakPtr{,Base}

The leak was caused by DeleteArrow() not being called.

BUG=179758
R=jar@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205345

[akalin, 2013-06-07 22:10:08]

+jar for review

(since you reviewed my original CL that introduced the leak)

[jar (doing other things), 2013-06-10 03:32:41]

Please add description which hints at what was going wrong with the original
CL... and is repaired in this CL.

https://codereview.chromium.org/15797010/diff/1/base/memory/weak_ptr_unittest.cc
File base/memory/weak_ptr_unittest.cc (right):

https://codereview.chromium.org/15797010/diff/1/base/memory/weak_ptr_unittest...
base/memory/weak_ptr_unittest.cc:448: TEST(WeakPtrTest,
NonOwnerThreadCanCopyAndAssignWeakPtr) {
Why did you move the two test methods down (below TEST(WeakPtrTest,
NonOwnerThreadCanDeleteWeakPtr) ) as it makes the review tools show separate
blocks (only makes it harder to review).

[akalin, 2013-06-10 17:58:21]

PTAL

https://codereview.chromium.org/15797010/diff/1/base/memory/weak_ptr_unittest.cc
File base/memory/weak_ptr_unittest.cc (right):

https://codereview.chromium.org/15797010/diff/1/base/memory/weak_ptr_unittest...
base/memory/weak_ptr_unittest.cc:448: TEST(WeakPtrTest,
NonOwnerThreadCanCopyAndAssignWeakPtr) {
On 2013/06/10 03:32:41, jar wrote:
> Why did you move the two test methods down (below TEST(WeakPtrTest,
> NonOwnerThreadCanDeleteWeakPtr) ) as it makes the review tools show separate
> blocks (only makes it harder to review).

I think that's the logical order of the tests, since it seems better to verify
that deletion on another thread works before relying on that fact in the two
tests I moved.

But it's not a big deal, so I moved it back.

[jar (doing other things), 2013-06-10 23:44:56]

lgtm

[akalin, 2013-06-10 23:46:22]

Committed patchset #2 manually as r205345 (presubmit successful).