Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 15797004: Cleanup WebKit prefixed names for classes in css directory. (Closed)

Created:
7 years, 6 months ago by darktears
Modified:
7 years, 6 months ago
CC:
blink-reviews, kenneth.christiansen, jsbell+bindings_chromium.org, chromiumbugtracker_adobe.com, eae+blinkwatch, leviw+renderwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, haraken, Nate Chapin
Visibility:
Public.

Description

Cleanup WebKit prefixed names for classes in css directory. Make sure we don't use prefixed naming inside Blink. The features are still exposed prefixed to the web, unprefixing them is a different story. This is part one of the renaming. R=eseidel@chromium.org, kenneth.r.christiansen@intel.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151418

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -1463 lines) Patch
M Source/bindings/scripts/CodeGeneratorV8.pm View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8CSSRuleCustom.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8CSSValueCustom.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/core.gypi View 8 chunks +15 lines, -15 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
A + Source/core/css/CSSMixFunctionValue.h View 1 chunk +11 lines, -11 lines 0 comments Download
A + Source/core/css/CSSMixFunctionValue.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
A + Source/core/css/CSSMixFunctionValue.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/css/CSSParser.h View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSParser.cpp View 28 chunks +52 lines, -52 lines 0 comments Download
A + Source/core/css/CSSRegionRule.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + Source/core/css/CSSRegionRule.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + Source/core/css/CSSRegionRule.idl View 1 chunk +3 lines, -2 lines 1 comment Download
A + Source/core/css/CSSSVGDocumentValue.h View 4 chunks +8 lines, -8 lines 0 comments Download
A + Source/core/css/CSSSVGDocumentValue.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
A + Source/core/css/CSSShaderValue.h View 4 chunks +11 lines, -11 lines 0 comments Download
A + Source/core/css/CSSShaderValue.cpp View 5 chunks +11 lines, -11 lines 0 comments Download
A + Source/core/css/CSSTransformValue.h View 2 chunks +12 lines, -12 lines 0 comments Download
A + Source/core/css/CSSTransformValue.cpp View 2 chunks +13 lines, -13 lines 0 comments Download
A + Source/core/css/CSSTransformValue.idl View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/css/CSSValue.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/css/CSSValue.cpp View 14 chunks +42 lines, -42 lines 0 comments Download
A + Source/core/css/CSSViewportRule.h View 4 chunks +8 lines, -8 lines 0 comments Download
A + Source/core/css/CSSViewportRule.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
A + Source/core/css/CSSViewportRule.idl View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/css/InspectorCSSOMWrappers.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/StyleRule.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
D Source/core/css/WebKitCSSMixFunctionValue.h View 1 chunk +0 lines, -61 lines 0 comments Download
D Source/core/css/WebKitCSSMixFunctionValue.cpp View 1 chunk +0 lines, -69 lines 0 comments Download
D Source/core/css/WebKitCSSMixFunctionValue.idl View 1 chunk +0 lines, -33 lines 0 comments Download
D Source/core/css/WebKitCSSRegionRule.h View 1 chunk +0 lines, -53 lines 0 comments Download
D Source/core/css/WebKitCSSRegionRule.cpp View 1 chunk +0 lines, -64 lines 0 comments Download
D Source/core/css/WebKitCSSRegionRule.idl View 1 chunk +0 lines, -35 lines 0 comments Download
D Source/core/css/WebKitCSSSVGDocumentValue.h View 1 chunk +0 lines, -61 lines 0 comments Download
D Source/core/css/WebKitCSSSVGDocumentValue.cpp View 1 chunk +0 lines, -81 lines 0 comments Download
D Source/core/css/WebKitCSSShaderValue.h View 1 chunk +0 lines, -80 lines 0 comments Download
D Source/core/css/WebKitCSSShaderValue.cpp View 1 chunk +0 lines, -111 lines 0 comments Download
D Source/core/css/WebKitCSSTransformValue.h View 1 chunk +0 lines, -87 lines 0 comments Download
D Source/core/css/WebKitCSSTransformValue.cpp View 1 chunk +0 lines, -104 lines 0 comments Download
D Source/core/css/WebKitCSSTransformValue.idl View 1 chunk +0 lines, -60 lines 0 comments Download
D Source/core/css/WebKitCSSViewportRule.h View 1 chunk +0 lines, -70 lines 0 comments Download
D Source/core/css/WebKitCSSViewportRule.cpp View 1 chunk +0 lines, -99 lines 0 comments Download
D Source/core/css/WebKitCSSViewportRule.idl View 1 chunk +0 lines, -34 lines 0 comments Download
M Source/core/css/resolver/FilterOperationResolver.cpp View 8 chunks +15 lines, -15 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 3 chunks +1 line, -3 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 4 chunks +5 lines, -7 lines 0 comments Download
M Source/core/css/resolver/StyleResolverState.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/TransformBuilder.cpp View 13 chunks +62 lines, -62 lines 0 comments Download
M Source/core/rendering/style/StylePendingShader.h View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
darktears
7 years, 6 months ago (2013-05-29 18:11:59 UTC) #1
kenneth.r.christiansen
lgtm, but it's a big change, easy to miss something
7 years, 6 months ago (2013-05-29 19:47:27 UTC) #2
kenneth.r.christiansen
https://codereview.chromium.org/15797004/diff/1/Source/core/css/CSSRegionRule.idl File Source/core/css/CSSRegionRule.idl (right): https://codereview.chromium.org/15797004/diff/1/Source/core/css/CSSRegionRule.idl#newcode32 Source/core/css/CSSRegionRule.idl:32: InterfaceName=WebKitCSSRegionRule the interface name doesn't need to change here? ...
7 years, 6 months ago (2013-05-29 19:47:35 UTC) #3
darktears
On 2013/05/29 19:47:35, kenneth.r.christiansen wrote: > https://codereview.chromium.org/15797004/diff/1/Source/core/css/CSSRegionRule.idl > File Source/core/css/CSSRegionRule.idl (right): > > https://codereview.chromium.org/15797004/diff/1/Source/core/css/CSSRegionRule.idl#newcode32 > ...
7 years, 6 months ago (2013-05-29 19:57:33 UTC) #4
darktears
On 2013/05/29 19:47:27, kenneth.r.christiansen wrote: > lgtm, but it's a big change, easy to miss ...
7 years, 6 months ago (2013-05-29 19:58:13 UTC) #5
darktears
On 2013/05/29 19:57:33, darktears wrote: > On 2013/05/29 19:47:35, kenneth.r.christiansen wrote: > > > https://codereview.chromium.org/15797004/diff/1/Source/core/css/CSSRegionRule.idl ...
7 years, 6 months ago (2013-05-29 20:02:56 UTC) #6
eseidel
lgtm I would like haraken or one of the bindings experts to give a lgtm ...
7 years, 6 months ago (2013-05-29 20:07:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/15797004/1
7 years, 6 months ago (2013-05-29 20:08:07 UTC) #8
darktears
On 2013/05/29 20:07:55, eseidel wrote: > lgtm > > I would like haraken or one ...
7 years, 6 months ago (2013-05-29 20:10:57 UTC) #9
darktears
7 years, 6 months ago (2013-05-29 21:14:02 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 manually as r151418 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698