Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 1579643007: Remove unnecessary dependencies. (Closed)

Created:
4 years, 11 months ago by Forrest Reiling
Modified:
4 years, 9 months ago
Reviewers:
cdotstout, viettrungluu
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@submit-0
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove unnecessary dependencies. Change-Id: Ia153f3334823dc12bfd2ad579c6f140b8a3cd051 BUG= R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7e97137db504ea7b32fe54e1fe792630953afe3a

Patch Set 1 #

Patch Set 2 : updated dependency #

Patch Set 3 : rebased on top of platform handle changes #

Patch Set 4 : harmless rebase #

Patch Set 5 : harmless rebase, nothing to see here #

Patch Set 6 : harmless rebase #

Patch Set 7 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M mojo/converters/geometry/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/converters/input_events/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/converters/native_viewport/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/converters/ozone_drm_gpu/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Forrest Reiling
4 years, 11 months ago (2016-01-19 21:24:04 UTC) #2
cdotstout
+vtl
4 years, 10 months ago (2016-02-01 16:34:59 UTC) #4
viettrungluu
lgtm
4 years, 10 months ago (2016-02-01 21:00:23 UTC) #5
Forrest Reiling
4 years, 10 months ago (2016-02-10 19:13:52 UTC) #6
Forrest Reiling
4 years, 9 months ago (2016-03-03 00:27:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as
7e97137db504ea7b32fe54e1fe792630953afe3a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698