Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1579643005: Add more dart:io related precompilation roots. (Closed)

Created:
4 years, 11 months ago by Vyacheslav Egorov (Google)
Modified:
4 years, 11 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add more dart:io related precompilation roots. File, Directory, Link and FileSystemException are allocated by the runtime code. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/8ea0f1728978bef4d07293980bcbb49189677331

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M runtime/bin/main.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
rmacnak
LGTM
4 years, 11 months ago (2016-01-11 20:58:25 UTC) #3
Vyacheslav Egorov (Google)
4 years, 11 months ago (2016-01-12 13:14:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8ea0f1728978bef4d07293980bcbb49189677331 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698