Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1579623004: libdisasm: Remove inclusion of windows.h (Closed)

Created:
4 years, 11 months ago by labath
Modified:
4 years, 11 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

libdisasm: Remove inclusion of windows.h windows.h defines exception_code as a macro, which conflicts with our use of the identifier in exception records. It appears that this particular include of windows.h is not needed, so instead of undefining the macro, I simply delete the include. Build tested with MSVC 2013. BUG= R=mark@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/2c03db146a6168c544f31d5454d7d36205b2baba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/third_party/libdisasm/libdis.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
labath
4 years, 11 months ago (2016-01-12 10:31:46 UTC) #2
Mark Mentovai
LGTM
4 years, 11 months ago (2016-01-12 15:42:37 UTC) #3
Mark Mentovai
4 years, 11 months ago (2016-01-12 15:43:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2c03db146a6168c544f31d5454d7d36205b2baba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698