Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1579603005: [turbofan] Tighter id-ing of exception value in handler blocks (Closed)

Created:
4 years, 11 months ago by Mircea Trofin
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, sigurds, Ben Goodger (Google)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

This change precisely identifies the live range of the exception operand in a handler block. This avoids confusing unrelated ranges, which may happen if escape analysis elides the exception operand. BUG=chromium:576195 LOG=N Committed: https://crrev.com/fd7339879e386453231c8f06d2b4285bb4316a96 Cr-Commit-Position: refs/heads/master@{#33271}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/compiler/register-allocator.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Mircea Trofin
4 years, 11 months ago (2016-01-12 23:06:51 UTC) #3
Jarin
lgtm. Thanks!
4 years, 11 months ago (2016-01-13 05:10:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579603005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579603005/1
4 years, 11 months ago (2016-01-13 05:13:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9698)
4 years, 11 months ago (2016-01-13 05:15:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579603005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579603005/1
4 years, 11 months ago (2016-01-13 17:05:10 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-13 17:24:23 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 17:25:26 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd7339879e386453231c8f06d2b4285bb4316a96
Cr-Commit-Position: refs/heads/master@{#33271}

Powered by Google App Engine
This is Rietveld 408576698