Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1579603004: Gather more information related to crash in InterceptNavigationThrottle (Closed)

Created:
4 years, 11 months ago by clamy
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gather more information related to crash in InterceptNavigationThrottle This CL temporarily adds more information and CHECKs to the InterceptNavigationThrottle code to better understand a crash I have not been able to reproduce locally (the crash is currently the top crasher on Android). BUG=570200 Committed: https://crrev.com/4b97a160d581394e370b39d6bbe6ea8350b6f80f Cr-Commit-Position: refs/heads/master@{#368927}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M components/navigation_interception/intercept_navigation_throttle.h View 1 chunk +4 lines, -1 line 0 comments Download
M components/navigation_interception/intercept_navigation_throttle.cc View 4 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
clamy
@mnaganov: PTAL. These are temporary checks to try to better understand a crash happening in ...
4 years, 11 months ago (2016-01-12 14:11:43 UTC) #3
mnaganov (inactive)
lgtm
4 years, 11 months ago (2016-01-12 16:40:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579603004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579603004/1
4 years, 11 months ago (2016-01-12 16:52:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 18:48:28 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 18:49:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b97a160d581394e370b39d6bbe6ea8350b6f80f
Cr-Commit-Position: refs/heads/master@{#368927}

Powered by Google App Engine
This is Rietveld 408576698