Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1579603002: Generalize all representations when reconfiguring a property of a strict Function subclass. (Closed)

Created:
4 years, 11 months ago by Igor Sheludko
Modified:
4 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Generalize all representations when reconfiguring a property of a strict Function subclass. BUG=chromium:575080 LOG=N Committed: https://crrev.com/405c7a68ab77576dfcb9ba22763590a82dea2d6c Cr-Commit-Position: refs/heads/master@{#33288}

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Addressing comments, skipping new test for interpreter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
M src/objects.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 2 chunks +25 lines, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-575080.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579603002/1
4 years, 11 months ago (2016-01-11 14:25:05 UTC) #2
Igor Sheludko
Toon, PTAL
4 years, 11 months ago (2016-01-11 14:25:22 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/12219) v8_win_rel_ng on ...
4 years, 11 months ago (2016-01-11 14:40:10 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579603002/20001
4 years, 11 months ago (2016-01-11 15:33:43 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/13954)
4 years, 11 months ago (2016-01-11 15:50:07 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579603002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579603002/60001
4 years, 11 months ago (2016-01-12 15:46:22 UTC) #13
Igor Sheludko
Addressed comments, PTAL again.
4 years, 11 months ago (2016-01-12 16:16:37 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-12 16:34:25 UTC) #17
Toon Verwaest
lgtm, thanks
4 years, 11 months ago (2016-01-14 09:27:08 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579603002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579603002/60001
4 years, 11 months ago (2016-01-14 10:23:36 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 11 months ago (2016-01-14 10:45:15 UTC) #22
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 10:45:42 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/405c7a68ab77576dfcb9ba22763590a82dea2d6c
Cr-Commit-Position: refs/heads/master@{#33288}

Powered by Google App Engine
This is Rietveld 408576698