Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 1579573004: Revert of [Proxies] Ship Proxies + Reflect (Closed)

Created:
4 years, 11 months ago by Michael Achenbach
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com, rmcilroy, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Proxies] Ship Proxies + Reflect (patchset #2 id:20001 of https://codereview.chromium.org/1580693002/ ) Reason for revert: [Sheriff] Breaks layout tests. Please fix upstream first. https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2032/builds/3587 https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3873 Original issue's description: > [Proxies] Ship Proxies + Reflect > > BUG=v8:3931, v8:1543 > LOG=Y > R=verwaest@chromium.org, rossberg@chromium.org > > Committed: https://crrev.com/9ce5162fd2a36daf318e0ec3838cd90f4e179168 > Cr-Commit-Position: refs/heads/master@{#33234} TBR=rossberg@chromium.org,verwaest@chromium.org,hablich@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3931, v8:1543 Committed: https://crrev.com/284010c8b3cf0d73bfdf8ecbf9dede21ce7eb772 Cr-Commit-Position: refs/heads/master@{#33236}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/flag-definitions.h View 2 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [Proxies] Ship Proxies + Reflect
4 years, 11 months ago (2016-01-12 13:07:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579573004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579573004/1
4 years, 11 months ago (2016-01-12 13:07:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 13:07:34 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 13:08:30 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/284010c8b3cf0d73bfdf8ecbf9dede21ce7eb772
Cr-Commit-Position: refs/heads/master@{#33236}

Powered by Google App Engine
This is Rietveld 408576698