fix #25409, error if a generic method argument did not have a corresponding parameter

fix #25409, error if a generic method argument did not have a corresponding parameter

R=leafp@google.com

Committed: https://github.com/dart-lang/sdk/commit/f114dc1073d2f8705ad819d83267c8b6fe95588b

[Jennifer Messerly, 2016-01-12 01:10:33]

jmesserly@google.com changed reviewers:
+ leafp@google.com

[Jennifer Messerly, 2016-01-12 01:11:00]

Description was changed from

==========
fix #25409, error if an argument did not have a corresponding parameter
==========

to

==========
fix #25409, error if a generic method argument did not have a corresponding
parameter
==========

[Leaf, 2016-01-13 00:43:10]

lgtm.

https://codereview.chromium.org/1579503005/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/static_type_analyzer.dart (right):

https://codereview.chromium.org/1579503005/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/static_type_analyzer.dart:1817:
ResolverVisitor.resolveArgumentsToParameters(
Can you add documentation to resolveArgumentsToParameters saying how it is
expected to behave when the arguments and parameters don't match up (I think
it's guaranteed to return the same number of elements as there are parameters,
and will put null in for any element it can't match up).

https://codereview.chromium.org/1579503005/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/strong/checker_test.dart (right):

https://codereview.chromium.org/1579503005/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/checker_test.dart:1402: String x =
/*severe:STATIC_TYPE_ERROR*/foo(1, 2);
Also add a call with too few arguments, and maybe an extra named argument or
missing named argument?

[Jennifer Messerly, 2016-01-13 19:10:36]

PTAL. I had to fix a bug in DDC's existing CodeChecker logic relating to named
parameters. It was causing incorrect behavior in this case:

T bar<T>({T x, T y}) => x;
main() {
  bar(x: '1', z: 42);
}

we correctly infer T as String, and correctly determine that "z" is a bogus
parameter. However CodeChecker would pretend it was passed as the second
positional argument, and then complain that "int" cannot be passed to "String"

https://codereview.chromium.org/1579503005/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/static_type_analyzer.dart (right):

https://codereview.chromium.org/1579503005/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/static_type_analyzer.dart:1817:
ResolverVisitor.resolveArgumentsToParameters(
On 2016/01/13 00:43:10, Leaf wrote:
> Can you add documentation to resolveArgumentsToParameters saying how it is
> expected to behave when the arguments and parameters don't match up (I think
> it's guaranteed to return the same number of elements as there are parameters,
> and will put null in for any element it can't match up).

Sure thing.

https://codereview.chromium.org/1579503005/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/strong/checker_test.dart (right):

https://codereview.chromium.org/1579503005/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/checker_test.dart:1402: String x =
/*severe:STATIC_TYPE_ERROR*/foo(1, 2);
On 2016/01/13 00:43:10, Leaf wrote:
> Also add a call with too few arguments, and maybe an extra named argument or
> missing named argument?

Good idea. Added.

[Leaf, 2016-01-13 19:17:46]

lgtm

[Jennifer Messerly, 2016-01-13 19:20:17]

Description was changed from

==========
fix #25409, error if a generic method argument did not have a corresponding
parameter
==========

to

==========
fix #25409, error if a generic method argument did not have a corresponding
parameter

R=leafp@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f114dc1073d2f8705ad819d83267c8b6fe95588b
==========

[Jennifer Messerly, 2016-01-13 19:20:18]

Committed patchset #2 (id:20001) manually as
f114dc1073d2f8705ad819d83267c8b6fe95588b (presubmit successful).