Cache auxiliary bitmap across draw frames

android_webview/native/java_browser_view_renderer_helper.cc

Index: android_webview/native/java_browser_view_renderer_helper.cc
diff --git a/android_webview/native/java_browser_view_renderer_helper.cc b/android_webview/native/java_browser_view_renderer_helper.cc
index b2cf4e981d82ec6d2f8cedc194d9627f923536bc..2b579627823845ce8a84138e3ca64873bb2d1b22 100644
--- a/android_webview/native/java_browser_view_renderer_helper.cc
+++ b/android_webview/native/java_browser_view_renderer_helper.cc
@@ -4,6 +4,7 @@
 
 #include "android_webview/native/java_browser_view_renderer_helper.h"
 
+#include "base/debug/trace_event.h"
 #include "jni/JavaBrowserViewRendererHelper_jni.h"
 
 using base::android::JavaRef;
@@ -20,15 +21,19 @@ JavaBrowserViewRendererHelper::~JavaBrowserViewRendererHelper() {
 ScopedJavaLocalRef<jobject> JavaBrowserViewRendererHelper::CreateBitmap(
     JNIEnv* env,
     int width,
-    int height) {
+    int height,
+    bool cache_result) {
+  TRACE_EVENT0("android_webview", "RendererHelper::CreateBitmap");

[boliu, 2013/05/23 02:52:13]

nit: can log cache_result, and ideally also log whether it created a new bitmap
or reused one

[joth, 2013/05/23 20:23:14]

Done (although it's mostly obvious in a trace from the relative timings)

   return width <= 0 || height <= 0 ? ScopedJavaLocalRef<jobject>() :
-      Java_JavaBrowserViewRendererHelper_createBitmap(env, width, height);
+      Java_JavaBrowserViewRendererHelper_createBitmap(env, width, height,
+                                                      cache_result);
 }
 
 void JavaBrowserViewRendererHelper::DrawBitmapIntoCanvas(
     JNIEnv* env,
     const JavaRef<jobject>& jbitmap,
     const JavaRef<jobject>& jcanvas) {
+  TRACE_EVENT0("android_webview", "RendererHelper::DrawBitmapIntoCanvas");
   Java_JavaBrowserViewRendererHelper_drawBitmapIntoCanvas(
       env, jbitmap.obj(), jcanvas.obj());
 }
@@ -37,6 +42,7 @@ ScopedJavaLocalRef<jobject>
 JavaBrowserViewRendererHelper::RecordBitmapIntoPicture(
     JNIEnv* env,
     const JavaRef<jobject>& jbitmap) {
+  TRACE_EVENT0("android_webview", "RendererHelper::RecordBitmapIntoPicture");
   return Java_JavaBrowserViewRendererHelper_recordBitmapIntoPicture(
       env, jbitmap.obj());
 }