Cache auxiliary bitmap across draw frames

android_webview/browser/browser_view_renderer_impl.cc

Index: android_webview/browser/browser_view_renderer_impl.cc
diff --git a/android_webview/browser/browser_view_renderer_impl.cc b/android_webview/browser/browser_view_renderer_impl.cc
index aacf9d416962fd8b8b4d367a330022072f5554fb..72aaf39b65c04da2db321c7ce174df3bf122ce80 100644
--- a/android_webview/browser/browser_view_renderer_impl.cc
+++ b/android_webview/browser/browser_view_renderer_impl.cc
@@ -342,7 +342,7 @@ bool BrowserViewRendererImpl::DrawSW(jobject java_canvas,
   if (!g_sw_draw_functions ||
       (pixels = g_sw_draw_functions->access_pixels(env, java_canvas)) == NULL) {
     ScopedJavaLocalRef<jobject> jbitmap(java_helper_->CreateBitmap(
-        env, clip.width(), clip.height()));
+        env, clip.width(), clip.height(), true));
     if (!jbitmap.obj())
       return false;
 
@@ -420,7 +420,7 @@ ScopedJavaLocalRef<jobject> BrowserViewRendererImpl::CapturePicture() {
   // If Skia versions are not compatible, workaround it by rasterizing the
   // picture into a bitmap and drawing it into a new Java picture.
   ScopedJavaLocalRef<jobject> jbitmap(java_helper_->CreateBitmap(
-      env, picture->width(), picture->height()));
+      env, picture->width(), picture->height(), false));

[kaanb, 2013/05/23 16:56:11]

Any reason we don't want to support it for CapturePicture?

[joth, 2013/05/23 20:23:14]

(this whole file is being deleted soon, but for the other version of this...)
The SkPicture has a shallow ref to any bitmaps drawn, but the client may hold
onto the picture for a long time. so if we reuse the bitmap for different
purposes, we'll corrupt previously drawn pictures.
Added a comment to the other place to explain this.

   if (!jbitmap.obj())
     return ScopedJavaLocalRef<jobject>();