Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1579463002: Restrict the scope of PointerFieldStorageTrait<>. (Closed)

Created:
4 years, 11 months ago by sof
Modified:
4 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restrict the scope of PointerFieldStorageTrait<>. Float it into ScopedDisposal<> as it isn't used anywhere else. R=haraken BUG= Committed: https://crrev.com/7bf4f642b2b3305b86efe163c61f6b04eda319ed Cr-Commit-Position: refs/heads/master@{#368552}

Patch Set 1 : revert adoptRef() move #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M third_party/WebKit/Source/platform/heap/Handle.h View 3 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579463002/1
4 years, 11 months ago (2016-01-10 20:12:54 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/100079)
4 years, 11 months ago (2016-01-10 20:20:44 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579463002/20001
4 years, 11 months ago (2016-01-10 20:35:50 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/6020) linux_chromium_gn_chromeos_rel on ...
4 years, 11 months ago (2016-01-10 20:44:19 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579463002/40001
4 years, 11 months ago (2016-01-10 20:46:53 UTC) #10
sof
please take a look.
4 years, 11 months ago (2016-01-10 22:34:44 UTC) #15
haraken
LGTM
4 years, 11 months ago (2016-01-11 01:51:11 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579463002/40001
4 years, 11 months ago (2016-01-11 06:20:32 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 11 months ago (2016-01-11 10:15:51 UTC) #22
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 10:18:13 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7bf4f642b2b3305b86efe163c61f6b04eda319ed
Cr-Commit-Position: refs/heads/master@{#368552}

Powered by Google App Engine
This is Rietveld 408576698