Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1579463002:
Restrict the scope of PointerFieldStorageTrait<>. (Closed)
|
Created:
4 years, 11 months ago by sof Modified:
4 years, 11 months ago CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRestrict the scope of PointerFieldStorageTrait<>.
Float it into ScopedDisposal<> as it isn't used anywhere
else.
R=haraken
BUG=
Committed: https://crrev.com/7bf4f642b2b3305b86efe163c61f6b04eda319ed
Cr-Commit-Position: refs/heads/master@{#368552}
Patch Set 1 : revert adoptRef() move #
Messages
Total messages: 24 (14 generated)
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579463002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579463002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579463002/40001
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
Description was changed from ========== Restrict the scope of PointerFieldStorageTrait<>. R= BUG= ========== to ========== Restrict the scope of PointerFieldStorageTrait<>. Float it into ScopedDisposal<> as it isn't used anywhere else. R= BUG= ==========
sigbjornf@opera.com changed reviewers: + oilpan-reviews@chromium.org
please take a look.
LGTM
Description was changed from ========== Restrict the scope of PointerFieldStorageTrait<>. Float it into ScopedDisposal<> as it isn't used anywhere else. R= BUG= ========== to ========== Restrict the scope of PointerFieldStorageTrait<>. Float it into ScopedDisposal<> as it isn't used anywhere else. R=haraken BUG= ==========
The CQ bit was unchecked by sigbjornf@opera.com
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1579463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1579463002/40001
Message was sent while issue was closed.
Description was changed from ========== Restrict the scope of PointerFieldStorageTrait<>. Float it into ScopedDisposal<> as it isn't used anywhere else. R=haraken BUG= ========== to ========== Restrict the scope of PointerFieldStorageTrait<>. Float it into ScopedDisposal<> as it isn't used anywhere else. R=haraken BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Restrict the scope of PointerFieldStorageTrait<>. Float it into ScopedDisposal<> as it isn't used anywhere else. R=haraken BUG= ========== to ========== Restrict the scope of PointerFieldStorageTrait<>. Float it into ScopedDisposal<> as it isn't used anywhere else. R=haraken BUG= Committed: https://crrev.com/7bf4f642b2b3305b86efe163c61f6b04eda319ed Cr-Commit-Position: refs/heads/master@{#368552} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7bf4f642b2b3305b86efe163c61f6b04eda319ed Cr-Commit-Position: refs/heads/master@{#368552} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
