Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1185)

Unified Diff: content/browser/push_messaging/push_messaging_router.cc

Issue 1579413004: Move push event dispatching out of ServiceWorkerVersion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix DispatchSimpleEvent comment Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/push_messaging/push_messaging_router.cc
diff --git a/content/browser/push_messaging/push_messaging_router.cc b/content/browser/push_messaging/push_messaging_router.cc
index 3f72a75e23dab94e99a2b0a20c7ce89caae82664..7b8deab5f036046b5d1c3756586c6fffed8240e5 100644
--- a/content/browser/push_messaging/push_messaging_router.cc
+++ b/content/browser/push_messaging/push_messaging_router.cc
@@ -10,6 +10,7 @@
#include "content/browser/service_worker/service_worker_context_wrapper.h"
#include "content/browser/service_worker/service_worker_registration.h"
#include "content/browser/service_worker/service_worker_storage.h"
+#include "content/common/service_worker/service_worker_messages.h"
#include "content/common/service_worker/service_worker_status_code.h"
#include "content/public/browser/browser_context.h"
#include "content/public/browser/browser_thread.h"
@@ -22,6 +23,7 @@ namespace {
void RunDeliverCallback(
const PushMessagingRouter::DeliverMessageCallback& deliver_message_callback,
PushDeliveryStatus delivery_status) {
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
base::Bind(deliver_message_callback, delivery_status));
@@ -87,11 +89,27 @@ void PushMessagingRouter::FindServiceWorkerRegistrationCallback(
// alive until the callback dies. Otherwise the registration could be
// released when this method returns - before the event is delivered to the
// service worker.
- base::Callback<void(ServiceWorkerStatusCode)> dispatch_event_callback =
+ version->RunAfterStartWorker(
+ base::Bind(&PushMessagingRouter::DeliverMessageToWorker,
+ make_scoped_refptr(version), service_worker_registration, data,
+ deliver_message_callback),
base::Bind(&PushMessagingRouter::DeliverMessageEnd,
- deliver_message_callback, service_worker_registration);
+ deliver_message_callback, service_worker_registration));
+}
- version->DispatchPushEvent(dispatch_event_callback, data);
+// static
+void PushMessagingRouter::DeliverMessageToWorker(
+ const scoped_refptr<ServiceWorkerVersion>& service_worker,
+ const scoped_refptr<ServiceWorkerRegistration>& service_worker_registration,
+ const std::string& data,
+ const DeliverMessageCallback& deliver_message_callback) {
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
+ int request_id = service_worker->StartRequest(
+ ServiceWorkerMetrics::EventType::PUSH,
+ base::Bind(&PushMessagingRouter::DeliverMessageEnd,
+ deliver_message_callback, service_worker_registration));
+ service_worker->DispatchSimpleEvent<ServiceWorkerHostMsg_PushEventFinished>(
+ request_id, ServiceWorkerMsg_PushEvent(request_id, data));
}
// static
« no previous file with comments | « content/browser/push_messaging/push_messaging_router.h ('k') | content/browser/service_worker/service_worker_version.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698